New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Down Fails in 3.3.2 if you don't have have a return char on sql statement. #117

Closed
h3adache opened this Issue Mar 19, 2018 · 9 comments

Comments

Projects
None yet
2 participants
@h3adache
Member

h3adache commented Mar 19, 2018

CREATE TABLE test.[Migration Failure] (
  ID BIGINT IDENTITY PRIMARY KEY,
  [Test] VARCHAR(255) NOT NULL
);
-- //@UNDO
DROP TABLE test.[Migration Failure];

up + down successfully completes but down is an empty statement.

CREATE TABLE test.[Migration Failure] (
  ID BIGINT IDENTITY PRIMARY KEY,
  [Test] VARCHAR(255) NOT NULL
);
-- //@UNDO
DROP TABLE test.[Migration Failure];

up + down successfully correctly. The only difference is adding a return after the DROP statement.
Probably relates to #101 but need to investigate more.

@h3adache h3adache added the bug label Mar 19, 2018

@h3adache h3adache self-assigned this Mar 19, 2018

@harawata

This comment has been minimized.

Member

harawata commented Mar 20, 2018

Thanks @h3adache ,

I thought I added a test for this, but apparently not.
Line 98 must be changed.

-        if (lineBuffer.length() > 0 && !undo && !inUndo) {
+        if (lineBuffer.length() > 0 && (!undo || inUndo)) {

This seems like a bad regression. Should we release 3.3.3 immediately?

@h3adache

This comment has been minimized.

Member

h3adache commented Mar 20, 2018

Nice, quick find! Yea, we should do a quick release for this one. Thanks!

@harawata harawata added this to the 3.3.3 milestone Mar 20, 2018

@harawata harawata closed this in 5153895 Mar 20, 2018

@harawata

This comment has been minimized.

Member

harawata commented Mar 20, 2018

3.3.3 is out. Thank you, @h3adache !

@h3adache

This comment has been minimized.

Member

h3adache commented Mar 20, 2018

Hi @harawata this bug is still there but on the down stage. It doesn't replace ${changelog} if it's not followed by a return character :P
I can look into it if you don't have time.

@harawata harawata reopened this Mar 21, 2018

@harawata harawata closed this in f318157 Mar 21, 2018

@harawata

This comment has been minimized.

Member

harawata commented Mar 21, 2018

@h3adache , XD
Sorry, I should've waited for your verification. It's fixed in the snapshot.

@h3adache

This comment has been minimized.

Member

h3adache commented Mar 21, 2018

@harawata thanks! I tried the 3.3.4-SNAPSHOT and it looks great!

@harawata

This comment has been minimized.

Member

harawata commented Mar 21, 2018

Thank you, @h3adache !
Let's wait for a while before releasing 3.3.4 ;D

@h3adache

This comment has been minimized.

Member

h3adache commented Mar 21, 2018

lol ok I'll keep testing 3.3.4-snapshot but we should release soon so people can take advantage of the new options and your performance enhancements without snapshot

@harawata harawata modified the milestones: 3.3.3, 3.3.4 Apr 6, 2018

@harawata

This comment has been minimized.

Member

harawata commented Apr 6, 2018

Hi @h3adache ,

I'll release 3.3.4 this weekend.
Please let me know if you've found something else.

@harawata harawata reopened this Apr 6, 2018

@harawata harawata closed this May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment