Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultResultSetType as global configuration #1056

Merged
merged 8 commits into from Jul 7, 2019

Conversation

@kazuki43zoo
Copy link
Member

commented Jul 17, 2017

I want to support the defaultResultSetType as global configuration.
By this change, we can change a result set type to SCROLL_SENSITIVE or SCROLL_INSENSITIVE from default(FORWARD_ONLY) by globally (and easily).

What do you think for this PR ?
Please review this.

Thanks.

@kazuki43zoo kazuki43zoo self-assigned this Jul 17, 2017

@harawata

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

After looking at #1334 #1344 , this seems to be a reasonable enhancement. 👍

@kazuki43zoo

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2018

@harawata Thanks for your reaction!
I've fixed conflict and update doc. Please confirm again when you have a time.

@harawata
Copy link
Member

left a comment

Thank you, @kazuki43zoo !

@kazuki43zoo kazuki43zoo requested a review from harawata Jul 6, 2019

@kazuki43zoo kazuki43zoo added this to the 3.5.2 milestone Jul 6, 2019

@kazuki43zoo kazuki43zoo force-pushed the kazuki43zoo:default-resultset-type branch from d93ae87 to 7765a86 Jul 7, 2019

@harawata
Copy link
Member

left a comment

Thanks for the update, @kazuki43zoo !
LGTM :)

@kazuki43zoo kazuki43zoo merged commit 6e9e4c2 into mybatis:master Jul 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kazuki43zoo kazuki43zoo deleted the kazuki43zoo:default-resultset-type branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.