New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replacing configuration properties on ProviderSqlSource #1061

Merged
merged 1 commit into from Jul 29, 2017

Conversation

Projects
None yet
2 participants
@kazuki43zoo
Member

kazuki43zoo commented Jul 27, 2017

Fixes gh-1057

Please review.

@harawata

This comment has been minimized.

Show comment
Hide comment
@harawata

harawata Jul 29, 2017

Member

Looks good! Thank you!

Member

harawata commented Jul 29, 2017

Looks good! Thank you!

@kazuki43zoo

This comment has been minimized.

Show comment
Hide comment
@kazuki43zoo

kazuki43zoo Jul 29, 2017

Member

@harawata Thanks for your review! I'll merge this.

Member

kazuki43zoo commented Jul 29, 2017

@harawata Thanks for your review! I'll merge this.

@kazuki43zoo kazuki43zoo merged commit 1af8f68 into mybatis:master Jul 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kazuki43zoo kazuki43zoo deleted the kazuki43zoo:gh-1057_allow-placeholder-on-sqlprovider branch Jul 29, 2017

@kazuki43zoo kazuki43zoo added this to the 3.4.5 milestone Jul 30, 2017

@kazuki43zoo kazuki43zoo self-assigned this Jul 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment