New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow calling a static provider method without instantiation #1131

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
3 participants
@kazuki43zoo
Member

kazuki43zoo commented Nov 7, 2017

Fixes gh-1130

@mybatis/committers
Please review this.

@kazuki43zoo kazuki43zoo changed the title from Allow calling a static provider method to Allow calling a static provider method without instantiation Nov 8, 2017

@harawata

This comment has been minimized.

Member

harawata commented Nov 8, 2017

It looks good to me. Thank you @kazuki43zoo !

@kazuki43zoo

This comment has been minimized.

Member

kazuki43zoo commented Nov 8, 2017

@harawata Thanks for your review!

@kazuki43zoo kazuki43zoo added this to the 3.4.6 milestone Nov 8, 2017

@kazuki43zoo kazuki43zoo self-assigned this Nov 8, 2017

@kazuki43zoo kazuki43zoo merged commit 00fd4ba into mybatis:master Nov 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kazuki43zoo kazuki43zoo deleted the kazuki43zoo:gh-1130 branch Nov 8, 2017

@tnicolas29200

This comment has been minimized.

tnicolas29200 commented Nov 8, 2017

Well done kazuki43zoo : a good implementation for calling a static provider ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment