Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous collection type bug fix. Ref #364 #1472

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@helloyou2012
Copy link
Contributor

helloyou2012 commented Jan 30, 2019

<collection /> does not have resultType attribute. Is it javaType?

@harawata

This comment has been minimized.

Copy link
Member

harawata commented Jan 30, 2019

Thank you, @helloyou2012 !

Did you get this error with your solution?
We might need to release 3.5.1 for this...

@harawata harawata self-assigned this Jan 30, 2019

@harawata harawata added the bug label Jan 30, 2019

@harawata harawata added this to the 3.5.1 milestone Jan 30, 2019

@harawata harawata merged commit 19d259f into mybatis:master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harawata added a commit that referenced this pull request Jan 30, 2019

@harawata

This comment has been minimized.

Copy link
Member

harawata commented Jan 30, 2019

Hi @helloyou2012 ,

This should be fixed in the latest 3.5.1-SNAPSHOT.
Are you OK with using SNAPSHOT for a while?
If not, I'll consult with the team.

I'm sorry for the inconvenience and thank you again for the PR!

Regards,
Iwao

@helloyou2012

This comment has been minimized.

Copy link
Contributor Author

helloyou2012 commented Jan 31, 2019

Thanks @harawata, I use 3.4.6 for a while.

@harawata

This comment has been minimized.

Copy link
Member

harawata commented Jan 31, 2019

@helloyou2012 ,

I'm sorry about the regression and appreciate your patience.
As there were many changes made in 3.5.0, I think we should wait for a while to see if there is any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.