New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add value attribute on provider annotations #1522
Add value attribute on provider annotations #1522
Conversation
Thank you for your work, @kazuki43zoo ! I can see the benefit, so adding @jeffgbutler @h3adache Any opinion? |
Hi @harawata , Thanks for your quick reaction!!
I have other opinion for this topic. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring seems to have an auto-processing mechanism based on @AliasFor
.
So no extra validation like this is necessary in Spring.
And I honestly don't see the benefit of providing an alias.
It makes users think 'which to choose?' or 'what is the difference?' even for a brief moment.
Anyway, this might be a matter of preference, so I'll approve.
We can add @deprecated
later if we want. :)
@harawata Thanks for approval.
OK. Let's think about good solution to be continued!! |
…viderannotation Add value attribute on provider annotations
I propose to support the
value
attributes on provider annotations(such as@InsertProvider
). In this change, developer can omit thetype
attribute as follow:The
type
attribute can use the alias forvalue
attribute. This change related with gh-1279. The gh-1279 allow to omitmethod
attribute, therefore this change is effective.WDYT?