Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FETCH FIRST on SQL builder class #1582

Merged
merged 5 commits into from Jun 29, 2019

Conversation

@kazuki43zoo
Copy link
Member

commented Jun 26, 2019

I've tried to support FETCH FIRST(support since ISO:SQL2008+) for limiting result rows.

WDYT?

Related Issues

@kazuki43zoo kazuki43zoo requested review from harawata and jeffgbutler Jun 26, 2019

@jeffgbutler
Copy link
Member

left a comment

Looks good to me

@harawata
Copy link
Member

left a comment

Nice work. Thank you, @kazuki43zoo !
I didn't test it with real DBs, but the test looks good.

src/main/java/org/apache/ibatis/jdbc/AbstractSQL.java Outdated Show resolved Hide resolved
@kazuki43zoo

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

I didn't test it with real DBs, but the test looks good.

I will consider to add tests using HSQLDB and PostgreSQL.

@kazuki43zoo kazuki43zoo self-assigned this Jun 27, 2019

@kazuki43zoo kazuki43zoo added this to the 3.5.2 milestone Jun 27, 2019

@kazuki43zoo kazuki43zoo merged commit 21bda4d into mybatis:master Jun 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kazuki43zoo kazuki43zoo deleted the kazuki43zoo:support-fetch-first branch Jun 29, 2019

kazuki43zoo added a commit that referenced this pull request Jun 29, 2019

@kazuki43zoo kazuki43zoo changed the title Support FETCH FIRST on SQL class Support FETCH FIRST on SQL builder class Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.