Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to assign single primitive parameter on SQL provider method #1604

Merged
merged 3 commits into from Jul 13, 2019

Conversation

@kazuki43zoo
Copy link
Member

commented Jul 13, 2019

Current implementation cannot use primitive type on SQL provider method. For details, see gh-1595.
I've fixed gh-1595 using based on solution that suggested by @harawata (See #1595 (comment)), however I've changed some implementations from suggested implementation by @harawata for keeping backward compatibility with 3.5.1 as follows:

  • target type for instanceof (ParamMap -> Map)
  • support to use together with ProviderContext and Map

@harawata WDYT?

@kazuki43zoo kazuki43zoo requested a review from harawata Jul 13, 2019

@kazuki43zoo kazuki43zoo force-pushed the kazuki43zoo:gh-1595 branch from 43c0554 to 9d68282 Jul 13, 2019

@kazuki43zoo kazuki43zoo self-assigned this Jul 13, 2019

@kazuki43zoo kazuki43zoo added the bug label Jul 13, 2019

@kazuki43zoo kazuki43zoo added this to the 3.5.2 milestone Jul 13, 2019

@kazuki43zoo kazuki43zoo merged commit 5fc85a6 into mybatis:master Jul 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kazuki43zoo kazuki43zoo deleted the kazuki43zoo:gh-1595 branch Jul 13, 2019

kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this pull request Jul 14, 2019

kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this pull request Jul 14, 2019

kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this pull request Jul 14, 2019

kazuki43zoo added a commit that referenced this pull request Jul 15, 2019

Merge pull request #1606 from kazuki43zoo/gh-1604-fix-broken-backward…
…-compatibility

Fix broken backward compatibility by gh-1604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.