Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow referencing result map from @One and @Many #1771

Merged

Conversation

moonService
Copy link
Contributor

@moonService moonService commented Dec 10, 2019

@many and @one add resultMapId

@moonService moonService changed the title Dev/add resultmap id to annotion many one Add resultmap id to annotion many one Dec 10, 2019
@harawata
Copy link
Member

harawata commented Dec 10, 2019

Thank you for the, @moonService !
I have been thinking about this for a while.
Please give me some time to check the details.

Copy link
Member

@harawata harawata left a comment

Thank you for the PR, @moonService !
I added a few change requests.
Let me know if you have any question.

@moonService
Copy link
Contributor Author

moonService commented Dec 24, 2019

@harawata At your request,I modified some places,please check them If you have time.

Copy link
Member

@harawata harawata left a comment

I just noticed that there are two files copyrighted by your organization. Please see the comments.

moonService and others added 2 commits Dec 27, 2019
- Applied formatter.
- Renamed tests to clarify intention.
- Removed redundant comments.
- Added license headers.
@harawata harawata force-pushed the dev/add_resultmapId_to_annotion_many_one branch from d519d24 to dd8d87e Compare Dec 27, 2019
@harawata harawata added this to the 3.5.5 milestone Dec 31, 2019
@harawata harawata self-assigned this Dec 31, 2019
@harawata harawata added the enhancement label Dec 31, 2019
@harawata
Copy link
Member

harawata commented Dec 31, 2019

Thank you, @moonService for the update!

Just to be safe, let me merge this after the 3.5.4 release.

@moonService
Copy link
Contributor Author

moonService commented Jan 8, 2020

@harawata ok

@harawata harawata changed the title Add resultmap id to annotion many one Allow referencing result map from @One and @Many Feb 5, 2020
@harawata harawata changed the title Allow referencing result map from @One and @Many Allow referencing result map from @One and @Many Feb 5, 2020
@harawata harawata merged commit c7c810a into mybatis:master Feb 5, 2020
1 check passed
@harawata
Copy link
Member

harawata commented Feb 5, 2020

It's merged. Thank you again, @moonService !

I plan to add columnPrefix once I find the time.
Please let me know if you are keen to work on it.

@moonService
Copy link
Contributor Author

moonService commented Feb 6, 2020

@harawata I added this on #1829

@harawata
Copy link
Member

harawata commented Feb 6, 2020

Thank you, @moonService !
I'll review it as soon as I get the time.

kazuki43zoo added a commit that referenced this issue Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants