Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add columnPrefix to @One and @Many #1829

Merged
merged 5 commits into from Feb 14, 2020

Conversation

moonService
Copy link
Contributor

@moonService moonService commented Feb 6, 2020

No description provided.

Copy link
Member

@harawata harawata left a comment

Mostly looks good! Thank you, @moonService !
There are two copyrighted files. Could you remove those headers?

@moonService
Copy link
Contributor Author

moonService commented Feb 12, 2020

@harawata please check it if you have time

@harawata
Copy link
Member

harawata commented Feb 12, 2020

Thanks for the update, @moonService !
And I'm sorry about the delay. There are a few complex usages I want to test before merging this.

harawata added 3 commits Feb 14, 2020
- Removed a wrong import.
- Column size should be large enough to contain the test data.
- Renamed role_name/roleName to name This is not an issue, but it unnecessarily makes the test harder to understand.
@harawata harawata changed the title @one and @many add columnPrefix Add columnPrefix to @One and @Many Feb 14, 2020
@harawata harawata self-assigned this Feb 14, 2020
@harawata harawata added the enhancement label Feb 14, 2020
@harawata harawata added this to the 3.5.5 milestone Feb 14, 2020
@harawata harawata merged commit ea8182c into mybatis:master Feb 14, 2020
1 check passed
@harawata
Copy link
Member

harawata commented Feb 15, 2020

@moonService ,
It's merged!. Thanks again for your contribution!

kazuki43zoo added a commit that referenced this issue Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants