Add option for allowing null value on foreach tag#1883
Merged
kazuki43zoo merged 1 commit intomybatis:masterfrom Dec 21, 2021
Merged
Add option for allowing null value on foreach tag#1883kazuki43zoo merged 1 commit intomybatis:masterfrom
kazuki43zoo merged 1 commit intomybatis:masterfrom
Conversation
Member
Author
|
@mybatis/committers WDYT this PR? |
Member
|
Thank you for your work, @kazuki43zoo ! This gets a few upvotes and the impact looks small, so I'm OK with it. |
Member
Author
|
@harawata Thx for your reaction!! I will rebase this PR. |
ce6df48 to
7738026
Compare
Member
Author
|
@harawata I've rebased and update doc. |
Member
|
Thank you, @kazuki43zoo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will propose to support new option for allowing
nullvalue oncollectionattribute offoreachtag.In this change, a developer can omit the
iftag as follow:Also, a developer can change the default
nullablevalue when thenullableattribute is omitted using global configuration as follow:XML configuration (
mybatis-config.xml):or
Java configuration(
Configurationclass):WDYT?