Fix wrong registration logic for LanguageDriver #914

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@splade

splade commented Feb 14, 2017

In the function public void register(LanguageDriver instance), when the local variable driver == null, we should put the "instance" object
in the "LANGUAGE_DRIVER_MAP", NOT the "driver" object.

splade added some commits Feb 14, 2017

Fix a logic error
In the function "public void register(LanguageDriver instance)", when the local variable "driver" is NULL, we should put the "instance" object
in the "LANGUAGE_DRIVER_MAP", NOT the "driver" object.
Merge pull request #1 from splade/Fix-a-logic-error-in-the-function-"…
…public-void-register(LanguageDriver-instance)"-of-the-class-"LanguageDriverRegistry"

Fix a logic error

@kazuki43zoo kazuki43zoo self-assigned this Feb 14, 2017

@kazuki43zoo kazuki43zoo added the bug label Feb 14, 2017

@kazuki43zoo kazuki43zoo added this to the 3.4.3 milestone Feb 14, 2017

@kazuki43zoo

This comment has been minimized.

Show comment
Hide comment
@kazuki43zoo

kazuki43zoo Feb 14, 2017

Member

@splade

Thank you for your contributing !
I've fix via 080db72 (adding test cases and polishing some logic).

Member

kazuki43zoo commented Feb 14, 2017

@splade

Thank you for your contributing !
I've fix via 080db72 (adding test cases and polishing some logic).

@kazuki43zoo kazuki43zoo changed the title from Fix a logic error to Fix wrong registration logic for LanguageDriver Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment