New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in JdbcTransaction.java (autoCommmit -> autoCommit) #941

Merged
merged 3 commits into from Mar 17, 2018

Conversation

Projects
None yet
4 participants
@luoxn28
Copy link
Contributor

luoxn28 commented Mar 3, 2017

update a variable name in JdbcTransaction class.

Update JdbcTransaction.java
update a variable name in JdbcTransaction class.
@kazuki43zoo

This comment has been minimized.

Copy link
Member

kazuki43zoo commented Mar 3, 2017

@luoxn28 Thank for your contribution.
However we can't merge yet. See #770.

@kazuki43zoo kazuki43zoo added this to the 3.5.0 milestone Mar 3, 2017

@hazendaz

This comment has been minimized.

Copy link
Member

hazendaz commented May 24, 2017

@kazuki43zoo @harawata Do we really think this breaks something?

@harawata

This comment has been minimized.

Copy link
Member

harawata commented May 24, 2017

@hazendaz
I am not sure. I could find only one use case that may be affected.
As it should not be too hard to fix, I am OK if you want to fix this in 3.4.x line.

@kazuki43zoo

This comment has been minimized.

Copy link
Member

kazuki43zoo commented May 24, 2017

Hi @hazendaz ,
I think impact of this change is very small. However I prefer to keep a backward compatibility in maintenance version release as possible as.

@harawata harawata changed the title Update JdbcTransaction.java Correct typo in JdbcTransaction.java (autoCommmit -> autoCommit) Jul 4, 2017

harawata added some commits Jul 4, 2017

@kazuki43zoo

This comment has been minimized.

Copy link
Member

kazuki43zoo commented Mar 16, 2018

@harawata Is this change apply on 3.5.0 ? or @Deprecated (3.5.0) -> remove future version(e.g. 4,0,0)?

@harawata

This comment has been minimized.

Copy link
Member

harawata commented Mar 16, 2018

@kazuki43zoo Let's just change it in 3.5.0. =D

@kazuki43zoo

This comment has been minimized.

Copy link
Member

kazuki43zoo commented Mar 16, 2018

OK!!

@kazuki43zoo kazuki43zoo merged commit cd2daad into mybatis:master Mar 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kazuki43zoo

This comment has been minimized.

Copy link
Member

kazuki43zoo commented Mar 17, 2018

@luoxn28 Thanks for your contribution. I've merged now!

@kazuki43zoo kazuki43zoo self-assigned this Mar 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment