New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor fix for introduction. #318
Conversation
I don't think this change is necessary.
这个修改没有必要。
EDIT: typo |
@kyao233 Could you check @CodeingBoy 's comment? |
I just want to make it's translation as close as its English version. At least, I think the subject in second sentence is neccessary. |
No, you should do mean-by-mean translations instead of word-by-word translations. The translated documentation needs not always fit in the original English documentation. For readability, you can re-express them in native language.
By comparing them, you will find that they're really really close. But reading the translated one will make you feel odd, you know, odd. So I rewrote to this:
By reordering parts of this sentences, better readability presents. From your point of view, you may rewrite to this:
No, that does not make sense in Chinese. At least, it's odd. So, please reconsider your changes. Read them several times before you submitting them, don't think about English one - you're reading a Chinese documentation! (unless you notice something BIG had dropped) |
+1 for 在这个示例中,通过注解来指定 SQL 语句,但是也可以使用 MyBatis 映射器的 XML 配置文件。 |
What I did is not word-by-word translation and I don't want to do that, the issue is translation could be different from its English version but should fully express its meaning. For the sentences in your example, I didn't see too much difference.For which one you prefer I think it's just personal opinion and majority wins. |
So in your view "it" is not "fully express its meaning", but "this library" will do? And expressing the effect is not "fully express its meaning", but with adding "it" is "fully express its meaning"? I don't see any difference since they are actually the same thing.
Read the diff of #297. If you still think it's all my "personal opinion", submit a reversion. Anyway, I do expressed my opinions about your changes, and I will not stand in your way again. If you insist that, go ahead and get merged. |
hahaha, OKOK, I will close my MR for this one. |
Great, thanks for your understanding. In fact, I'm very happy to see users start contributing to documentations. |
@CodeingBoy and @kyao233, Thanks for your contributing! Contributions are always welcome. |
Make sentence more smooth.