[video] links not correct #1625

Closed
Destroy666x opened this Issue Nov 17, 2014 · 1 comment

Projects

None yet

2 participants

@Destroy666x
Member

1.8.2 update breaks the [video] links when one of these is enabled:

  • UCP -> Edit Options -> untick Display videos in posts.
  • ACP -> Configuration -> Clickable Smilies and BB Code -> Parse [video] MyCode To Guests -> No
  • ACP -> Forums & Posts -> [forum] -> Edit Forum Settings -> untick Yes, allow [video] code in posts (requires MyCode to be turned on)

Changing urlencode() to htmlspecialchars_uni() should work just fine if I'm not mistaken.

EDIT: seems to work for me. And it should be used for images $url and both $name too to keep the HTML properly validated (required & -> & conversion etc.).

@Destroy666x Destroy666x added this to the 1.8.3 milestone Nov 17, 2014
@Stefan-ST Stefan-ST added a commit to Stefan-ST/mybb that referenced this issue Nov 19, 2014
@Stefan-ST Stefan-ST Fixes #1625 [video] links not correct 7e478aa
@Stefan-ST Stefan-ST added s:fixed and removed s:confirmed labels Nov 19, 2014
@Stefan-ST Stefan-ST self-assigned this Nov 19, 2014
@Stefan-ST
Member

@Destroy666x htmlspecialchars_uni doesn't work since the whole post is already sanitized (unless HTML is enabled). Used mycode_parse_url instead as it handles special characters.

@Stefan-ST Stefan-ST added a commit to Stefan-ST/mybb that referenced this issue Nov 20, 2014
@Stefan-ST Stefan-ST Fixes #1625 [video] links not correct 2468b8f
@Stefan-ST Stefan-ST modified the milestone: 1.8.3, 1.8.4 Nov 20, 2014
@Destroy666x Destroy666x removed the p:high label Nov 21, 2014
@Destroy666x Destroy666x closed this in #1637 Nov 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment