Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with multiple recipients at PMs #1966

Closed
Stefan-MyBB opened this issue Apr 16, 2015 · 10 comments
Closed

Problem with multiple recipients at PMs #1966

Stefan-MyBB opened this issue Apr 16, 2015 · 10 comments
Labels
b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference s:confirmed Status: Confirmed. Retested and found the issue exists t:bug Type: Bug. An issue causing error / flaw / malfunction

Comments

@Stefan-MyBB
Copy link
Contributor

Send a PM to multiple recipients and then have a look to the usernames of the recipients (see attached image).
Sometimes the names of the recipients are shown and sometimes not. I have also sent a PM on another board, where no username was shown at all but only N/A ("keine Angabe").....

Original thread: Problem with multiple recipients at PMs

@Stefan-MyBB Stefan-MyBB added t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists b:1.8 Branch: 1.8.x labels Apr 16, 2015
@Destroy666x Destroy666x added this to the 1.8.6 milestone Apr 16, 2015
@Destroy666x
Copy link
Contributor

Whoever will be fixing this, don't forget about these 2 (query optimisation and PM search sorting by sender bug): http://community.mybb.com/thread-168978-post-1150102.html#pid1150102 or feel free to move them to other issues.

@Destroy666x Destroy666x added the p:medium Priority: Medium. Issues to be resolved with normal preference label Apr 16, 2015
@JN-Jones JN-Jones modified the milestones: 1.8.6, 1.8.7 Aug 26, 2015
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.7, 1.8.8 Mar 2, 2016
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.8, 1.8.9 Aug 31, 2016
@JN-Jones
Copy link
Contributor

@mybb/developers Can somebody look at this? There seem to be fixes available which should be considered and created a PR with them.

@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.9, 1.8.10 Dec 15, 2016
@Eldenroot
Copy link
Contributor

@Matslom - can you please check this?

@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.10, 1.8.11 Jan 8, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.11, 1.8.12 Apr 1, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.12, 1.8.11 Apr 1, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.12, 1.8.13 May 22, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.13, 1.8.14 Nov 6, 2017
@dvz dvz removed this from the 1.8.14 milestone Nov 22, 2017
@Eldenroot
Copy link
Contributor

MyBB team, still valid?
@effone @euantorano

@Sama34
Copy link
Contributor

Sama34 commented Jan 4, 2019

I'm unsure if this was ever fixed but I couldn't replicate in a live board using the last MyBB version.
image

@euantorano
Copy link
Member

euantorano commented Jan 4, 2019 via email

@Sama34
Copy link
Contributor

Sama34 commented Jan 4, 2019

If Stefan solution was correct, it was applied in b01d134

However, I'm unable to guess if Destroyer's reports are still correct regarding the following lines:
https://github.com/mybb/mybb/blob/feature/private.php#L258-L362 (sorting by sender)
https://github.com/mybb/mybb/blob/feature/private.php#L325 (recipients redundant query)
https://github.com/mybb/mybb/blob/feature/private.php#L2189 (recipients redundant query)

If somebody can confirm such bugs to be fixed I think we can close this without issues.

@effone
Copy link
Member

effone commented Jan 5, 2019

I have done this (or similar) patch already, but it was not this issue?
I am sure my patch got merged, it was a comma / space placing /parsing issue at frontend, select2...

@Eldenroot
Copy link
Contributor

So what about queries mentioned above?

@Ben-MyBB
Copy link
Member

I can't seem to replicate this so going to go ahead and close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference s:confirmed Status: Confirmed. Retested and found the issue exists t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Development

No branches or pull requests

9 participants