Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close Thread doesn't work via reply #2022

Closed
Destroy666x opened this issue Jun 5, 2015 · 9 comments
Closed

Close Thread doesn't work via reply #2022

Destroy666x opened this issue Jun 5, 2015 · 9 comments
Assignees
@Stefan-MyBB
Labels
b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.8

Comments

@Destroy666x
Copy link
Contributor

Close Thread doesn't work via reply/quick reply...

https://github.com/mybb/mybb/blob/featur...#L889-L901

Original thread: Close Thread doesn't work via reply

EDIT: also: http://community.mybb.com/thread-171504-post-1161753.html#pid1161753
@Destroy666x Destroy666x added t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists b:1.8 Branch: 1.8.x labels Jun 5, 2015
@Destroy666x Destroy666x added this to the 1.8.6 milestone Jun 5, 2015
@Destroy666x Destroy666x self-assigned this Jun 5, 2015
@Destroy666x Destroy666x added s:in-progress Status: In Progress. Some work completed p:medium Priority: Medium. Issues to be resolved with normal preference and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Jun 5, 2015
@Sama34
Copy link
Contributor

Sama34 commented Jun 15, 2015

#1463

@JN-Jones JN-Jones modified the milestones: 1.8.6, 1.8.7 Aug 26, 2015
@dvz dvz mentioned this issue Oct 4, 2015
Closed
@Eldenroot
Copy link
Contributor

Is it bugged only in postbit quick reply?

@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.7, 1.8.8 Mar 2, 2016
@thunderclap82
Copy link

Is there a way to manually fix this bug until a proper update comes along? I'm still experiencing it in 1.8.7.

@Sama34
Copy link
Contributor

Sama34 commented May 17, 2016

IIRC this was fixed within #1922

@Eldenroot
Copy link
Contributor

@Sama34 - this issue is still here :( annoying

@Sama34
Copy link
Contributor

Sama34 commented May 17, 2016

What do you mean by "here"? The master branch?

@Eldenroot
Copy link
Contributor

At least in MyBB 1.8.7 still bugged

@thunderclap82
Copy link

That's the version of MyBB I have too. (1.8.7) The bug is still present in my copy.

@Destroy666x
Copy link
Contributor Author

Destroy666x commented May 17, 2016 •
edited

IIRC this was fixed within #1922

That PR introduced the bug, not fixed it. I'll try to finish the PR ASAP, but feel free to take it over.

beverloo added a commit to beverloo/mybb that referenced this issue Jun 2, 2016
@beverloo
Fix mybb#2022: Enable opening/closing threads again by replying
cc96538 
This bug was introduced by mybb#1922, and is obvious on lines 876 and 883 of that PR.

Also switch $thread['closed'] with $closed in the conditionals because (a) it's been cached for a reason, and (b) the $closed variable is being modified within them. It reads better.
@Stefan-MyBB Stefan-MyBB mentioned this issue Jun 26, 2016
Merged
@Stefan-MyBB Stefan-MyBB added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:in-progress Status: In Progress. Some work completed labels Jun 26, 2016
Starpaul20 added a commit that referenced this issue Jun 26, 2016
@Starpaul20
Merge pull request #2429 from Stefan-ST/fix-2022
21df167 
Fixes #2022 Close Thread doesn't work via reply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stefan-MyBB Stefan-MyBB

Labels
b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.8
Development

No branches or pull requests
6 participants
@Stefan-MyBB @Eldenroot @Sama34 @JN-Jones @Destroy666x @thunderclap82