New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery Conversion #251

Closed
nmalcolm opened this Issue Mar 1, 2014 · 70 comments

Comments

Projects
None yet
10 participants
@nmalcolm
Contributor

nmalcolm commented Mar 1, 2014

With Nathan's departure from the team, this post has been re-written and is now maintained by Pirata Nervo

I have added a TODO list below

This issue documents areas which need converting to jQuery. This is an attempt to make converting what's left easier, and making it clear how much work needs to be done.

  • Admin CP
    • theme.js (split into two: theme_properties.js and theme.js)
    • peeker.js
    • Implement modals where necessary (popupWindow)
      • Mail Error logs
      • Mail Logs
      • Mass Mail
      • IP Lookup
    • Replace CodePress by CodeMirror
    • Fix popupMenu
    • Re-write admin.js (contains delete confirmation)
    • Re-write mycode_sandbox.js (handles the sandbox for MyCode)
    • Re-write quick_perm_editor.js (needs a new Sortable plugin)
    • Re-write tabs.js
    • Re-write users.js (note: doesn't seem to have anything important?)
    • Re-write view_manager.js (requires a new Sortable plugin)
    • SCEditor must be used in the Signature field (Edit User) instead of the old editor (#539)
    • The Show Additional Options link when adding a forum needs to be fixed
    • Settings search box needs to be fixed
    • Replace hardcoded text in JS by language variables
      • admin/jscripts/search.js
      • admin/jscripts/mycode_sandbox.js
      • admin/jscripts/themes.js
  • Forum front-end
    • Implement Select2 #375 (replace Autocomplete.js)
    • Implement modals where necessary (popupWindow parameter fixes; PHP code changes; Template changes)
      • Buddy List popup
      • Add reputation
      • Report reputation
      • Report post (re-write thread.js)
      • Report user
      • Get IP info (ModCP -> IP Search)
      • MSN/AIM/YAHOO
      • Who Posted
    • Inline Edit (Forum Display -> Edit subject on hold) (inline_edit.js)
    • Quick Reply (re-write thread.js ; uses jEditable)
    • Quick Edit (re-write thread.js)
    • Multi Quote (re-write post.js and re-write thread.js)
    • Insert Into Post (attachment)
    • Remove attachment (re-write post.js)
    • Replace existing editor by SCEditor
    • Inline Moderation (re-write inline_moderation.js)
    • Registration form validation (re-write validator.js)
    • Confirm dialogues replaced by Impromptu
    • Convert popupMenu (Note: can be found in jquery.plugins.js now)
    • Replace alerts by jGrowl notifications (jGrowl can be found jquery.plugins.js)
      Below you can find detailed information about what's left.
    • Add Modals plugin (jquery modal can be found in jquery.plugins.js)
    • Add Impromptu plugin (Impromptu can be found in jquery.plugins.js)
    • Add bbcodes_sceditor.js (comes from the SCEditor plugin for MyBB - no point in re-inventing the wheel)
    • Captcha (re-write captcha.js)
    • Mark as Read (re-write general.js)
    • popupWindow (re-write general.js)
    • Delete calendar event (re-write general.js)
    • Delete reputation (re-write general.js)
    • Submit reputation (re-write general.js)
    • Change Language (re-write general.js)
    • Detect DST change (re-write general.js)
    • Dismiss PM notice (re-write general.js)
    • Delete announcement (re-write general.js)
    • Expandable/Collapsible (re-write general.js)
    • Implement jQuery Cookie plugin (appended to general.js)
    • Fix ratings (re-write rating.js)
    • Quick delete post (re-write thread.js)
    • Show ignored post (re-write thread.js)
    • UserCP Edit Lists (Buddy/Ignore) (re-write usercp.js)
    • UserCP Select from buddies in compose message #629
    • Select All boxes
    • ModCP Mass Controls
    • Calendar (onfocus events must be converted)
    • Replace hardcoded text in JS by language variables
      • usercp.js
      • thread.js
      • rating.js
      • post.js
      • inline_moderation.js
      • inline_edit.js
      • general.js
      • captcha.js
      • report.js
    • Convert smilies box
    • Warnings - Send PM Notification (if SCEditor is invisible by default, the height of the iframe and LTR textarea is not properly calculated and therefore when we ticked the Send PM checkbox to show the editor box, it had 0px height; this was fixed by hiding the editor after the document has been loaded) - related to samclarke/SCEditor#276

Feel free to point out any I've missed.

@nmalcolm nmalcolm added 1.8 labels Mar 1, 2014

nmalcolm pushed a commit that referenced this issue Mar 3, 2014

@nmalcolm nmalcolm modified the milestones: 1.8.0, 1.8 Beta 1 Mar 21, 2014

@PirataNervo PirataNervo self-assigned this Apr 3, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Apr 3, 2014

Contributor

typeahead.js deleted in #375. I have edited your first post.

Contributor

PirataNervo commented Apr 3, 2014

typeahead.js deleted in #375. I have edited your first post.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Apr 6, 2014

Contributor

For form validation I suggest this:
http://jqueryvalidation.org/

Contributor

PirataNervo commented Apr 6, 2014

For form validation I suggest this:
http://jqueryvalidation.org/

PirataNervo added a commit that referenced this issue Apr 6, 2014

Working on #251 JQuery Conversion
Fixed Report User modal on profile; Fixed "Information on this IP
Address" modal on IP Search - ModCP.

PirataNervo added a commit that referenced this issue Apr 6, 2014

Working on #251 JQuery Conversion
Fixed "Information on this IP Address" modal on "Get IP" page. Fixed
"Report" button on the reputation list on the user reputation details.
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Apr 6, 2014

Contributor

Most of the jQuery TODOs on the forum front-end are done. I'm going through the rest of them now so we can focus on the ACP ASAP.

Contributor

PirataNervo commented Apr 6, 2014

Most of the jQuery TODOs on the forum front-end are done. I'm going through the rest of them now so we can focus on the ACP ASAP.

PirataNervo added a commit that referenced this issue Apr 13, 2014

Working on #251 jQuery Conversion
MyBB.whoPosted() works properly now.

PirataNervo added a commit that referenced this issue Apr 13, 2014

Working on #251 jQuery Conversion
Fixed PM Tickbox not working properly. Actually almost fixed it. Because
there's still a bug which won't display the message in the textarea
unless the box is shown by default (which isn't). This happens because
the SCEditor textarea height is 0px and therefore we can't see the
message! If we refresh with the box ticked, the height is no longer 0px
and we can see the message.

PirataNervo added a commit that referenced this issue Apr 13, 2014

Working on #251 jQuery Conversion
TODO:
- Fix issues with AJAX/Remote username availability
- Add validation for CAPTCHA.
- Take care of {$validator_extra} in member.php
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Apr 13, 2014

Contributor

Started the work on the validator replacement.

TODO:

  • Fix issues with AJAX/Remote username availability
  • Add validation for CAPTCHA.
  • Take care of {$validator_extra} in member.php
  • Take care of required profile fields.
Contributor

PirataNervo commented Apr 13, 2014

Started the work on the validator replacement.

TODO:

  • Fix issues with AJAX/Remote username availability
  • Add validation for CAPTCHA.
  • Take care of {$validator_extra} in member.php
  • Take care of required profile fields.

PirataNervo added a commit that referenced this issue May 7, 2014

Working on jQuery Conversion #251
Check All checkboxes work fine now.
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 7, 2014

Contributor

Check All checkboxes (only used in the ACP according to my research) are now working fine - edited first post.

Contributor

PirataNervo commented May 7, 2014

Check All checkboxes (only used in the ACP according to my research) are now working fine - edited first post.

PirataNervo added a commit that referenced this issue May 7, 2014

Working on jQuery Conversion #251
Fixed bunch of "onfocus" attributes on template calendar_addevent

PirataNervo added a commit that referenced this issue May 7, 2014

Working on jQuery Conversion #251
Better use properties than attributes in this case

PirataNervo added a commit that referenced this issue May 7, 2014

Working on jQuery Conversion #251
Mass Controls in Moderator Queue now working
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 7, 2014

Contributor

Add Calendar - onfocus attributes now working properly.
Mass Controls on ModCP Moderator Queue now working properly.

Contributor

PirataNervo commented May 7, 2014

Add Calendar - onfocus attributes now working properly.
Mass Controls on ModCP Moderator Queue now working properly.

@JN-Jones

This comment has been minimized.

Show comment
Hide comment
@JN-Jones

JN-Jones May 12, 2014

Contributor

Ok, I've searched a bit:

  • MyBB.whoPosted() is missing
  • After adding a reputation from the reputation overview, the site should be reloaded (at least we do this in 1.6

Still searching :P

Contributor

JN-Jones commented May 12, 2014

Ok, I've searched a bit:

  • MyBB.whoPosted() is missing
  • After adding a reputation from the reputation overview, the site should be reloaded (at least we do this in 1.6

Still searching :P

@askamn

This comment has been minimized.

Show comment
Hide comment
@askamn

askamn May 16, 2014

Will XHR be converted to jQuery?
Because I don't see it here.

askamn commented May 16, 2014

Will XHR be converted to jQuery?
Because I don't see it here.

PaulBender added a commit that referenced this issue May 17, 2014

Working on jQuery Conversion #251
The Who Posted? pop-up now works

PirataNervo added a commit that referenced this issue May 18, 2014

Working on #251 jQuery Conversion
All popupWindow calls have been fixed in the AdminCP.
Fixed a bug related to IP address printing the ACP (noticed while fixing
modals).
The IP address info is now output from the ACP instead of being output
from modcp.php?action=iplookup&address=X
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 18, 2014

Contributor

@askamn I'm not sure I understand your question. For XHR in jQuery AJAX calls, please see http://api.jquery.com/jquery.ajax/

Contributor

PirataNervo commented May 18, 2014

@askamn I'm not sure I understand your question. For XHR in jQuery AJAX calls, please see http://api.jquery.com/jquery.ajax/

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 18, 2014

Contributor

Fixed all popupWindow problems in the ACP as well as a bug related to IP addresses in the ACP - IP Lookup.

Contributor

PirataNervo commented May 18, 2014

Fixed all popupWindow problems in the ACP as well as a bug related to IP addresses in the ACP - IP Lookup.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 18, 2014

Contributor

@PaulBender please reference here what was fixed so we can keep track of changes by name as well please. In this case, saying "implemented whoPosted" would suffice :)

Contributor

PirataNervo commented May 18, 2014

@PaulBender please reference here what was fixed so we can keep track of changes by name as well please. In this case, saying "implemented whoPosted" would suffice :)

PirataNervo added a commit that referenced this issue May 28, 2014

Working on #251 jQuery Conversion
Converted inline settings search to jQuery
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

Settings inline search converted successfully

Contributor

PirataNervo commented May 28, 2014

Settings inline search converted successfully

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

@WildcardSearch if you could please work on the language fixes I'd appreciate. I'm going to replace Typeahead now and then all that's left is finish the SCEditor conversion for signatures in the ACP and then fix the remaining bugs which are assigned to me.

Contributor

PirataNervo commented May 28, 2014

@WildcardSearch if you could please work on the language fixes I'd appreciate. I'm going to replace Typeahead now and then all that's left is finish the SCEditor conversion for signatures in the ACP and then fix the remaining bugs which are assigned to me.

PirataNervo added a commit that referenced this issue May 28, 2014

Working on #251 jQuery Conversion
Removed unneeded comments

PirataNervo added a commit that referenced this issue May 28, 2014

Working on #251 jQuery Conversion
Replaced Typeahead in users.php by Select2 (remaining: 0)
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

Typeahead (was still being used in Find Users - users.php) replaced by Select2

Contributor

PirataNervo commented May 28, 2014

Typeahead (was still being used in Find Users - users.php) replaced by Select2

@WildcardSearch

This comment has been minimized.

Show comment
Hide comment
@WildcardSearch

WildcardSearch May 28, 2014

Member

@PirataNervo okay I'll try to get that done in the morning.

Member

WildcardSearch commented May 28, 2014

@PirataNervo okay I'll try to get that done in the morning.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

All known jQuery conversion bugs are fixed at time of writing - @WildcardSearch all that's left is writing the language strings properly and adding the SCEditor to the signature field on the ACP.

Contributor

PirataNervo commented May 28, 2014

All known jQuery conversion bugs are fixed at time of writing - @WildcardSearch all that's left is writing the language strings properly and adding the SCEditor to the signature field on the ACP.

@ATofighi

This comment has been minimized.

Show comment
Hide comment
@ATofighi

ATofighi May 28, 2014

Contributor

@PirataNervo okay, I will create a new PR for it soon.

Contributor

ATofighi commented May 28, 2014

@PirataNervo okay, I will create a new PR for it soon.

@WildcardSearch

This comment has been minimized.

Show comment
Hide comment
@WildcardSearch

WildcardSearch May 28, 2014

Member

@WildcardSearch all that's left is writing the language strings properly and adding the SCEditor to the signature field on the ACP.

Working on that today.

Member

WildcardSearch commented May 28, 2014

@WildcardSearch all that's left is writing the language strings properly and adding the SCEditor to the signature field on the ACP.

Working on that today.

@WildcardSearch

This comment has been minimized.

Show comment
Hide comment
@WildcardSearch

WildcardSearch May 28, 2014

Member

The language is done in #613

Member

WildcardSearch commented May 28, 2014

The language is done in #613

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

Woot woot woot (going to check if all files are fixed now)

Contributor

PirataNervo commented May 28, 2014

Woot woot woot (going to check if all files are fixed now)

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

Confirmed. All that's left now is implementing the SCEditor on ACP -> Users -> Edit user -> Signature.
And fix #552 (for now :P)

@WildcardSearch if you could pick one it would be a great help - unless you have other issues to work on (if that's the case I prefer that you work on them as these are not so important).

PS. Fixing the bug is easier than implementing the editor (this one is tricky).

Contributor

PirataNervo commented May 28, 2014

Confirmed. All that's left now is implementing the SCEditor on ACP -> Users -> Edit user -> Signature.
And fix #552 (for now :P)

@WildcardSearch if you could pick one it would be a great help - unless you have other issues to work on (if that's the case I prefer that you work on them as these are not so important).

PS. Fixing the bug is easier than implementing the editor (this one is tricky).

@WildcardSearch

This comment has been minimized.

Show comment
Hide comment
@WildcardSearch

WildcardSearch May 29, 2014

Member

SCEditor must be used in the Signature field (Edit User) instead of the old editor

Done in #615

Member

WildcardSearch commented May 29, 2014

SCEditor must be used in the Signature field (Edit User) instead of the old editor

Done in #615

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on mybb#251 jQuery Conversion
Fixes Additional Options link (toggle) when adding forum

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on mybb#251 jQuery Conversion
Converted inline settings search to jQuery

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on mybb#251 jQuery Conversion
Removed unneeded comments

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on mybb#251 jQuery Conversion
Replaced Typeahead in users.php by Select2 (remaining: 0)

@PirataNervo PirataNervo added the jquery label May 29, 2014

@PirataNervo PirataNervo added the fixed label May 31, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 31, 2014

Contributor

The jQuery conversion is now complete.

Contributor

PirataNervo commented May 31, 2014

The jQuery conversion is now complete.

@WildcardSearch

This comment has been minimized.

Show comment
Hide comment
@WildcardSearch
Member

WildcardSearch commented May 31, 2014

👊

@PaulBender PaulBender referenced this issue Jun 3, 2014

Closed

jQuery issues #701

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment