Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftMailer library to handle the sending of emails #2909

Open
euantorano opened this issue Nov 18, 2017 · 3 comments

Comments

@euantorano
Copy link
Member

commented Nov 18, 2017

The current mailhandler setup works for most cases, but over the years we have encountered issues with several email systems where emails would fail to send.

As email is a fairly important component of the system, making use of a well tested and highly capable third party library used by many other software projects should help aleviate some of the issues we've sene in the past and take some pressure of maintaining the mail transport mechanisms off the team.

SwiftMailer is just such a library and is used in a wide variety of frameworks and applications. It should be fairly easy to integrate with the MyBB core since all emails are sent through the my_mail funciton, meaning we should eb able to modify a single function to get things working.

@euantorano euantorano created this issue from a note in MyBB 1.10 (Enhancements) Nov 18, 2017

@euantorano euantorano self-assigned this Nov 18, 2017

@euantorano

This comment has been minimized.

Copy link
Member Author

commented Nov 18, 2017

One note regarding SwiftMailer is that it provides two transports out of the box:

  • SMTP
  • Sendmail

It doesn't support using the PHP mail() function at all, though the two transports above should be enough for most cases. The PHP mail() function is generally advised against using de to many issues with it, mostly security related to escaping shell arguments when it is configured to use sendmail.

@euantorano euantorano added b:1.9 and removed b:1.10 labels Dec 4, 2018

@euantorano euantorano added this to the 1.9.0 milestone Dec 4, 2018

@euantorano euantorano added this to In progress in MyBB 1.9.0 Dec 4, 2018

@kawaii

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Note: this implementation has been superseded by Symfony Mime - it just depends on Euan's time as to when we get it pushed into the core.

@euantorano

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

I'm planning on implementing symfony/mailer as soon as I've finished the rebase.

@euantorano euantorano moved this from In progress to To do in MyBB 1.9.0 Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.