New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grammar issue in upgrade script #3393

Closed
andrewjs18 opened this Issue Aug 16, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@andrewjs18
Contributor

andrewjs18 commented Aug 16, 2018

the word 'in' needs to be added here:

Welcome to the installation wizard for MyBB 1.8.18. MyBB has detected it is already configured this directory.

so it reads like so:

Welcome to the installation wizard for MyBB 1.8.18. MyBB has detected it is already configured in this directory.

@andrewjs18 andrewjs18 added the b:1.8 label Aug 16, 2018

@Eldenroot

This comment has been minimized.

Contributor

Eldenroot commented Aug 17, 2018

EDIT: Nevermind, I opened a new PR to get one bug less :)

Eldenroot added a commit to Eldenroot/mybb that referenced this issue Aug 17, 2018

@effone effone added this to the 1.8.19 milestone Aug 18, 2018

@dvz dvz added t:bug and removed s:feedback labels Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment