Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing of Twig templates from the ACP #3686

Open
euantorano opened this issue May 31, 2019 · 8 comments
Open

Allow editing of Twig templates from the ACP #3686

euantorano opened this issue May 31, 2019 · 8 comments

Comments

@euantorano
Copy link
Member

@euantorano euantorano commented May 31, 2019

We need to be able to modify Twig templates from within the ACP, rather than requiring file-system access.

@euantorano euantorano added this to the 1.9.0 milestone May 31, 2019
@euantorano euantorano added this to To do in MyBB 1.9.0 via automation May 31, 2019
@kawaii
Copy link
Member

@kawaii kawaii commented May 31, 2019

I just want to CC @Shade- in here since I do very vaguely remember a discussion where we ruminated on the possibility of merging his FAStyle plugin into the core, which would drastically overhaul the template and stylesheet editing experience.

Loading

@andrewjs18
Copy link
Contributor

@andrewjs18 andrewjs18 commented May 31, 2019

I think pretty much everyone who edits the theme/template system heavily installs FASTyle so I'd definitely be in favor of using it as a way to improve the UX in the admin cp.

Loading

@Shade-
Copy link
Contributor

@Shade- Shade- commented Jun 13, 2019

Sorry for the delay, was busy. FASTyle is theoretically already capable of handling Twig files (as a CodeMirror extension exists already, it's just a matter of loading it and changing a bunch of lines), as I showcased back when I was converting templates. Some changes are needed though, especially regarding filesystem handling; but that should be easy enough given the plugin already handles scripts.

I'll hit you up when I get some more spare time.

Loading

@euantorano
Copy link
Member Author

@euantorano euantorano commented Jun 13, 2019

Loading

@Shade-
Copy link
Contributor

@Shade- Shade- commented Aug 31, 2019

Not sure if you still want to go with FASTyle. Apart from the aforementioned issues, which would be pretty easy to solve, I can foresee two issues:

  • my coding style does not adhere to MyBB's standards. I am not sure I have the time to convert it to yours;
  • the current FASTyle theme suits my likings, but it differs considerably from MyBB's old and new ones.

Let me know. I have some spare time after 15 sep.

Loading

@euantorano
Copy link
Member Author

@euantorano euantorano commented Aug 31, 2019

I need to look at FASTyle itself, as it's been a while.

Note that the 1.9 code style is different to 1.8 and follows PSR standards instead, so your standards may actually be fine.

Loading

@Shade-
Copy link
Contributor

@Shade- Shade- commented Aug 31, 2019

I follow my own standards, I just like to write as I want. Aka, not consistent at all 😁 Let me know anyway.

Loading

@euantorano
Copy link
Member Author

@euantorano euantorano commented Aug 31, 2019

I'll try find some time to have a look this weekend and let you know.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MyBB 1.9.0
  
To do
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants