Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin CP PIN #38

Closed
DiogoParrinha opened this issue Feb 14, 2013 · 9 comments
Closed

Admin CP PIN #38

DiogoParrinha opened this issue Feb 14, 2013 · 9 comments
Labels
b:1.8 Branch: 1.8.x t:enhancement Type: Enhancement. Contains minor improvements
Milestone
1.8 Beta 1

Comments

@DiogoParrinha
Copy link
Contributor

http://community.mybb.com/thread-105587.html

Simple as that.
@ghost ghost assigned DiogoParrinha Feb 14, 2013
DiogoParrinha pushed a commit that referenced this issue Feb 14, 2013
Admin CP PIN #38
cc498d6 
Adds an optional secret PIN to the Admin CP login
@DiogoParrinha
Copy link
Contributor Author

config.php written by the install script already contains the new variable but should we add the same thing to an upgrade script?

@PenguinPaul
Copy link
Contributor

Yes, it should be added on upgrade.

@PenguinPaul
Copy link
Contributor

Perhaps we could add a little on-screen number pad as well for additional security against keyloggers

@JordanMussi
Copy link
Contributor

@PenguinPaul That would be good, depending on what the user wants.

@SuperSpyTX
Copy link

This would be a great feature to integrate into MyBB.

@nmalcolm
Copy link
Contributor

@PenguinPaul I don't think that's necessary. It might help somewhat against keyloggers but for a RAT it's useless. I can understand such a feature for a banking website but I don't think it's needed for a forum system. It would be better as a plugin.

DiogoParrinha pushed a commit that referenced this issue Feb 15, 2013
Fixes bug #39 - related to feature #38
cc2dd9e 
$config['security_pin'] should obviously be $config['secret_pin']
@euantorano
Copy link
Member

Definitely agreed with @nmalcolm - if the user wants to use an ons creen keyboard, most OSes have one built in.

@nmalcolm
Copy link
Contributor

nmalcolm commented Dec 9, 2013

@PirataNervo This is completed, yes?

@nmalcolm
Copy link
Contributor

I'm closing this out as it looks like everything is completed here.

@nmalcolm nmalcolm added this to the 1.8.0 milestone Mar 21, 2014
DiogoParrinha pushed a commit that referenced this issue May 19, 2014
Fixes #38 Submit and Mod Tools not showing in ACP User Edit
4d5592b
PenguinPaul pushed a commit that referenced this issue May 19, 2014
Fixes Issue #38
3fceea5 
Adds a </div> so that the submit button isn't in the avatar tab.
PenguinPaul pushed a commit that referenced this issue May 19, 2014
Revert "Fixes Issue #38"
dcff588 
This reverts commit 3fceea5.
PenguinPaul pushed a commit that referenced this issue May 19, 2014
Fixes #38 Submit & Mod Tools gone in ACP User Edit
7897f68
@DiogoParrinha DiogoParrinha modified the milestones: 1.8 Beta 1, 1.8.0 Jul 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Milestone
1.8 Beta 1
Development

No branches or pull requests
6 participants
@euantorano @nmalcolm @SuperSpyTX @DiogoParrinha @PenguinPaul @JordanMussi