Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin CP PIN #38

Closed
DiogoParrinha opened this issue Feb 14, 2013 · 9 comments
Closed

Admin CP PIN #38

DiogoParrinha opened this issue Feb 14, 2013 · 9 comments

Comments

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Feb 14, 2013

@ghost ghost assigned DiogoParrinha Feb 14, 2013
DiogoParrinha pushed a commit that referenced this issue Feb 14, 2013
Adds an optional secret PIN to the Admin CP login
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Feb 14, 2013

config.php written by the install script already contains the new variable but should we add the same thing to an upgrade script?

@PenguinPaul
Copy link
Contributor

@PenguinPaul PenguinPaul commented Feb 14, 2013

Yes, it should be added on upgrade.

@PenguinPaul
Copy link
Contributor

@PenguinPaul PenguinPaul commented Feb 15, 2013

Perhaps we could add a little on-screen number pad as well for additional security against keyloggers

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Feb 15, 2013

@PenguinPaul That would be good, depending on what the user wants.

@SuperSpyTX
Copy link

@SuperSpyTX SuperSpyTX commented Feb 15, 2013

This would be a great feature to integrate into MyBB.

@nmalcolm
Copy link
Contributor

@nmalcolm nmalcolm commented Feb 15, 2013

@PenguinPaul I don't think that's necessary. It might help somewhat against keyloggers but for a RAT it's useless. I can understand such a feature for a banking website but I don't think it's needed for a forum system. It would be better as a plugin.

DiogoParrinha pushed a commit that referenced this issue Feb 15, 2013
$config['security_pin'] should obviously be $config['secret_pin']
@euantorano
Copy link
Member

@euantorano euantorano commented Feb 15, 2013

Definitely agreed with @nmalcolm - if the user wants to use an ons creen keyboard, most OSes have one built in.

@nmalcolm
Copy link
Contributor

@nmalcolm nmalcolm commented Dec 9, 2013

@PirataNervo This is completed, yes?

@nmalcolm
Copy link
Contributor

@nmalcolm nmalcolm commented Dec 22, 2013

I'm closing this out as it looks like everything is completed here.

@nmalcolm nmalcolm closed this Dec 22, 2013
@nmalcolm nmalcolm added this to the 1.8.0 milestone Mar 21, 2014
PenguinPaul pushed a commit that referenced this issue May 19, 2014
Adds a </div> so that the submit button isn't in the avatar tab.
PenguinPaul pushed a commit that referenced this issue May 19, 2014
This reverts commit 3fceea5.
@DiogoParrinha DiogoParrinha modified the milestones: 1.8 Beta 1, 1.8.0 Jul 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.