New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin CP PIN #38

Closed
PirataNervo opened this Issue Feb 14, 2013 · 9 comments

Comments

Projects
None yet
6 participants
@PirataNervo
Contributor

PirataNervo commented Feb 14, 2013

@ghost ghost assigned PirataNervo Feb 14, 2013

PirataNervo added a commit that referenced this issue Feb 14, 2013

Admin CP PIN #38
Adds an optional secret PIN to the Admin CP login
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Feb 14, 2013

Contributor

config.php written by the install script already contains the new variable but should we add the same thing to an upgrade script?

Contributor

PirataNervo commented Feb 14, 2013

config.php written by the install script already contains the new variable but should we add the same thing to an upgrade script?

@PenguinPaul

This comment has been minimized.

Show comment
Hide comment
@PenguinPaul

PenguinPaul Feb 14, 2013

Contributor

Yes, it should be added on upgrade.

Contributor

PenguinPaul commented Feb 14, 2013

Yes, it should be added on upgrade.

@PenguinPaul

This comment has been minimized.

Show comment
Hide comment
@PenguinPaul

PenguinPaul Feb 15, 2013

Contributor

Perhaps we could add a little on-screen number pad as well for additional security against keyloggers

Contributor

PenguinPaul commented Feb 15, 2013

Perhaps we could add a little on-screen number pad as well for additional security against keyloggers

@JordanMussi

This comment has been minimized.

Show comment
Hide comment
@JordanMussi

JordanMussi Feb 15, 2013

Contributor

@PenguinPaul That would be good, depending on what the user wants.

Contributor

JordanMussi commented Feb 15, 2013

@PenguinPaul That would be good, depending on what the user wants.

@SuperSpyTX

This comment has been minimized.

Show comment
Hide comment
@SuperSpyTX

SuperSpyTX Feb 15, 2013

This would be a great feature to integrate into MyBB.

SuperSpyTX commented Feb 15, 2013

This would be a great feature to integrate into MyBB.

@nmalcolm

This comment has been minimized.

Show comment
Hide comment
@nmalcolm

nmalcolm Feb 15, 2013

Contributor

@PenguinPaul I don't think that's necessary. It might help somewhat against keyloggers but for a RAT it's useless. I can understand such a feature for a banking website but I don't think it's needed for a forum system. It would be better as a plugin.

Contributor

nmalcolm commented Feb 15, 2013

@PenguinPaul I don't think that's necessary. It might help somewhat against keyloggers but for a RAT it's useless. I can understand such a feature for a banking website but I don't think it's needed for a forum system. It would be better as a plugin.

PirataNervo added a commit that referenced this issue Feb 15, 2013

Fixes bug #39 - related to feature #38
$config['security_pin'] should obviously be $config['secret_pin']
@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Feb 15, 2013

Member

Definitely agreed with @nmalcolm - if the user wants to use an ons creen keyboard, most OSes have one built in.

Member

euantorano commented Feb 15, 2013

Definitely agreed with @nmalcolm - if the user wants to use an ons creen keyboard, most OSes have one built in.

@nmalcolm

This comment has been minimized.

Show comment
Hide comment
@nmalcolm

nmalcolm Dec 9, 2013

Contributor

@PirataNervo This is completed, yes?

Contributor

nmalcolm commented Dec 9, 2013

@PirataNervo This is completed, yes?

@nmalcolm

This comment has been minimized.

Show comment
Hide comment
@nmalcolm

nmalcolm Dec 22, 2013

Contributor

I'm closing this out as it looks like everything is completed here.

Contributor

nmalcolm commented Dec 22, 2013

I'm closing this out as it looks like everything is completed here.

@nmalcolm nmalcolm closed this Dec 22, 2013

@nmalcolm nmalcolm added this to the 1.8.0 milestone Mar 21, 2014

PenguinPaul pushed a commit that referenced this issue May 19, 2014

Paul H
Fixes Issue #38
Adds a </div> so that the submit button isn't in the avatar tab.

PenguinPaul pushed a commit that referenced this issue May 19, 2014

Paul H
Revert "Fixes Issue #38"
This reverts commit 3fceea5.

@PirataNervo PirataNervo modified the milestones: 1.8 Beta 1, 1.8.0 Jul 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment