Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "banned" datacache #3878

Closed
dvz opened this issue Jan 14, 2020 · 0 comments · Fixed by #3879
Closed

Remove "banned" datacache #3878

dvz opened this issue Jan 14, 2020 · 0 comments · Fixed by #3879
Labels
b:1.8 s:resolved t:optimization
Milestone

Comments

@dvz
Copy link
Contributor

dvz commented Jan 14, 2020

Remove the banned data cache entry and rely on the user group's isbannedgroup value instead to determine banned status, fetching additional data from the mybb_banned table on positive result.

The status is used for instant ban lift checks for the visiting user (https://github.com/mybb/mybb/blob/mybb_1822/inc/class_session.php#L251).
MyBB installations that don't use the isbannedgroup type (Yes, this is a banned group) will expire account bans through the Half-hourly User Cleanup task.

The query used for the banned notice may no longer be necessary.

Related: #3876, #3685, https://community.mybb.com/thread-214400.html

@dvz dvz added b:1.8 t:optimization s:review-needed labels Jan 14, 2020
euantorano pushed a commit that referenced this issue Mar 7, 2020
* Rely on user groups' `isbannedgroup` instead of `banned` datacache for ban data

* Remove `banned` datacache and its usage
@euantorano euantorano added s:resolved and removed s:review-needed labels Mar 7, 2020
@dvz dvz added this to the 1.8.23 milestone Mar 7, 2020
lairdshaw pushed a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
[Rebased for 1.9 by Laird]

* Rely on user groups' `isbannedgroup` instead of `banned` datacache for ban data

* Remove `banned` datacache and its usage
@dvz dvz mentioned this issue Feb 23, 2022
2 tasks
lairdshaw added a commit to lairdshaw/mybb that referenced this issue Feb 23, 2022
…" datacache

The (manual) rebasing onto the 1.9 branch of PR mybb#3878 was incomplete, as @dvz pointed out here: mybb#4522 (comment)

Supersedes mybb#4523
dvz pushed a commit that referenced this issue Feb 24, 2022
…che (#4524)

The (manual) rebasing onto the 1.9 branch of PR #3878 was incomplete, as @dvz pointed out here: #4522 (comment)

Supersedes #4523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 s:resolved t:optimization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants