Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread View Mode cannot be set to Use Default but selects Threaded/Linear depending on default set by administrator #4085

Closed
Ben-MyBB opened this issue Jun 21, 2020 · 0 comments · Fixed by #4102
Closed

Thread View Mode cannot be set to Use Default but selects Threaded/Linear depending on default set by administrator #4085

Ben-MyBB opened this issue Jun 21, 2020 · 0 comments · Fixed by #4102
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.23

Comments

@Ben-MyBB
Copy link
Member

In UserCP > Edit Options
If someone opts for "Thread View Mode" as "Use Default"; MyBB renders the select option for "Thread View Mode" as per current setting; resulting the user setting gets updated with default value, rather than "Use Default".

Let me explain with steps.

  1. Open ACP » Settings » Show Thread Options, set "Usenet Style Thread View" to "Yes".
  2. Open UCP > Edit Options. Select "Thread View Mode" as "Use Default". Save settings. Notice, after saving the settings and page load the select dropdown appears as "Threaded" selected, not "Use Default".
  3. Again open ACP  » Settings » Show Thread Options, set "Usenet Style Thread View" to "No".
  4. Open UCP > Edit Options. Watch, the setting still shows "Threaded" whereas current default is "Linear". User setting got updated with last default, in place of "Use Default".

Original thread: Thread View Mode setting dishonors default
@Ben-MyBB Ben-MyBB added b:1.8 Branch: 1.8.x s:confirmed Status: Confirmed. Retested and found the issue exists t:bug Type: Bug. An issue causing error / flaw / malfunction labels Jun 21, 2020
@rajat315315 rajat315315 mentioned this issue Jun 29, 2020
Merged
@JordanMussi JordanMussi added s:review-needed Status: Review Needed. Possible solution submitted and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Jun 29, 2020
@JordanMussi JordanMussi changed the title Thread View Mode setting dishonors default Thread View Mode cannot be set to Use Default but selects Threaded/Linear depending on default set by administrator Jul 2, 2020
JordanMussi added a commit that referenced this issue Jul 2, 2020
@rajat315315 @JordanMussi
Fixes #4085 Thread View Mode cannot be set to Use Default (#4102)
16667c3 
Co-authored-by: Jordan Mussi <JordanMussi@users.noreply.github.com>
@JordanMussi JordanMussi added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:review-needed Status: Review Needed. Possible solution submitted labels Jul 2, 2020
@JordanMussi JordanMussi added this to the 1.8.23 milestone Jul 2, 2020
lairdshaw pushed a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
@rajat315315 @JordanMussi @lairdshaw
Fixes mybb#4085 Thread View Mode cannot be set to Use Default (mybb#4102
c043e62 
)

Co-authored-by: Jordan Mussi <JordanMussi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.23
Development

Successfully merging a pull request may close this issue.

Fixes #4085 Thread View Mode cannot be set to Use Default rajat315315/mybb
2 participants
@JordanMussi @Ben-MyBB