Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum Statistics Improvements #434

Closed
1 task done
Sama34 opened this issue Apr 28, 2014 · 13 comments
Closed
1 task done

Forum Statistics Improvements #434

Sama34 opened this issue Apr 28, 2014 · 13 comments
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@Sama34
Copy link
Contributor

Sama34 commented Apr 28, 2014

The following has been accepted:

  • Top referrer.
@Sama34 Sama34 added this to the 1.8 Beta 2 milestone Apr 28, 2014
@Sama34 Sama34 self-assigned this Apr 28, 2014
@JitMaharaj JitMaharaj assigned JitMaharaj and unassigned Sama34 May 18, 2014
@JitMaharaj
Copy link

JitMaharaj commented May 18, 2014

Added in commit a2c926f

@Sama34 Sama34 assigned Starpaul20 and unassigned JitMaharaj May 19, 2014
@Sama34 Sama34 modified the milestones: 1.8 Beta 1, 1.8 Beta 2 May 26, 2014
@Sama34
Copy link
Contributor Author

Sama34 commented May 26, 2014

Thanks @darkmew!

May be we can we cache the results of the stats page two times a day or add a setting? @PirataNervo, @PaulBender, @stefan-st.

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented May 27, 2014

I'd personally add a setting to turn this on or off.

@Starpaul20 Starpaul20 removed their assignment May 27, 2014
@JitMaharaj
Copy link

JitMaharaj commented May 28, 2014

You mean setting to show the top referrer or to cache.

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented May 29, 2014

I'm a bit confused here - note that I'm not GitHub expert, far from that, hence my question - but you committed directly first and I can't find those changes? But then you have a PR with code standards fixed. @Sama34 @darkmew your PR seems fine, I'm just confused about the first commit but not seeing anything in stats.php affected by your changes.

@JordanMussi
Copy link
Contributor

JordanMussi commented May 30, 2014

That first commit doesn't seem to be on any branch, thus there are no changes to be seen.

@Sama34 Sama34 self-assigned this May 31, 2014
@Sama34 Sama34 removed the fixed label May 31, 2014
@Sama34 Sama34 modified the milestones: 1.8 Beta 2, 1.8 Beta 1 May 31, 2014
@Sama34
Copy link
Contributor Author

Sama34 commented May 31, 2014

Right, I have moved this to MS -> Beta 2 since it wouldn't be making it to Beta 1.

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented May 31, 2014

@Sama34 sounds good.

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 27, 2014

@darkmew we should add a setting for this as it adds an extra query and some admins may want to turn it off. Beta 2 ETA is closing in.

@Sama34
Copy link
Contributor Author

Sama34 commented Jun 28, 2014

I meant to cache everything in the stats page and reload every X time. A setting should be added for the time interval.

@mybb/developers

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 28, 2014

Sure, why not.
@darkmew can you finish this before Beta 2 ETA?

@JitMaharaj
Copy link

JitMaharaj commented Jun 29, 2014

Probably won't make the ETA by tomorrow due to work constraints. Moving to beta3

@JitMaharaj JitMaharaj added this to the 1.8 Beta 3 milestone Jun 29, 2014
@JitMaharaj JitMaharaj removed this from the 1.8 Beta 2 milestone Jun 29, 2014
@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 30, 2014

Closing this. Caching will be resolved in Beta 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

5 participants