Forum Statistics Improvements #434

Closed
Sama34 opened this Issue Apr 28, 2014 · 13 comments

Comments

Projects
None yet
5 participants
@Sama34
Contributor

Sama34 commented Apr 28, 2014

The following has been accepted:

  • Top referrer.

@Sama34 Sama34 added this to the 1.8 Beta 2 milestone Apr 28, 2014

@Sama34 Sama34 self-assigned this Apr 28, 2014

@Darkmew Darkmew assigned Darkmew and unassigned Sama34 May 18, 2014

@Darkmew

This comment has been minimized.

Show comment
Hide comment
@Darkmew

Darkmew May 18, 2014

Added in commit a2c926f

Darkmew commented May 18, 2014

Added in commit a2c926f

@Darkmew Darkmew added the fixed label May 18, 2014

@Sama34 Sama34 assigned PaulBender and unassigned Darkmew May 19, 2014

@Sama34 Sama34 modified the milestones: 1.8 Beta 1, 1.8 Beta 2 May 26, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 May 26, 2014

Contributor

Thanks @Darkmew!

May be we can we cache the results of the stats page two times a day or add a setting? @PirataNervo, @PaulBender, @Stefan-ST.

Contributor

Sama34 commented May 26, 2014

Thanks @Darkmew!

May be we can we cache the results of the stats page two times a day or add a setting? @PirataNervo, @PaulBender, @Stefan-ST.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 27, 2014

Contributor

I'd personally add a setting to turn this on or off.

Contributor

PirataNervo commented May 27, 2014

I'd personally add a setting to turn this on or off.

@PaulBender PaulBender removed their assignment May 27, 2014

@Darkmew

This comment has been minimized.

Show comment
Hide comment
@Darkmew

Darkmew May 28, 2014

You mean setting to show the top referrer or to cache.

Darkmew commented May 28, 2014

You mean setting to show the top referrer or to cache.

@Darkmew Darkmew referenced this issue May 28, 2014

Merged

Top referrer #601

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 29, 2014

Contributor

I'm a bit confused here - note that I'm not GitHub expert, far from that, hence my question - but you committed directly first and I can't find those changes? But then you have a PR with code standards fixed. @Sama34 @Darkmew your PR seems fine, I'm just confused about the first commit but not seeing anything in stats.php affected by your changes.

Contributor

PirataNervo commented May 29, 2014

I'm a bit confused here - note that I'm not GitHub expert, far from that, hence my question - but you committed directly first and I can't find those changes? But then you have a PR with code standards fixed. @Sama34 @Darkmew your PR seems fine, I'm just confused about the first commit but not seeing anything in stats.php affected by your changes.

@JordanMussi

This comment has been minimized.

Show comment
Hide comment
@JordanMussi

JordanMussi May 30, 2014

Contributor

That first commit doesn't seem to be on any branch, thus there are no changes to be seen.

Contributor

JordanMussi commented May 30, 2014

That first commit doesn't seem to be on any branch, thus there are no changes to be seen.

@Sama34 Sama34 self-assigned this May 31, 2014

@Sama34 Sama34 removed the fixed label May 31, 2014

@Sama34 Sama34 modified the milestones: 1.8 Beta 2, 1.8 Beta 1 May 31, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 May 31, 2014

Contributor

Right, I have moved this to MS -> Beta 2 since it wouldn't be making it to Beta 1.

Contributor

Sama34 commented May 31, 2014

Right, I have moved this to MS -> Beta 2 since it wouldn't be making it to Beta 1.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 31, 2014

Contributor

@Sama34 sounds good.

Contributor

PirataNervo commented May 31, 2014

@Sama34 sounds good.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 27, 2014

Contributor

@Darkmew we should add a setting for this as it adds an extra query and some admins may want to turn it off. Beta 2 ETA is closing in.

Contributor

PirataNervo commented Jun 27, 2014

@Darkmew we should add a setting for this as it adds an extra query and some admins may want to turn it off. Beta 2 ETA is closing in.

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jun 28, 2014

Contributor

I meant to cache everything in the stats page and reload every X time. A setting should be added for the time interval.

@mybb/developers

Contributor

Sama34 commented Jun 28, 2014

I meant to cache everything in the stats page and reload every X time. A setting should be added for the time interval.

@mybb/developers

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 28, 2014

Contributor

Sure, why not.
@Darkmew can you finish this before Beta 2 ETA?

Contributor

PirataNervo commented Jun 28, 2014

Sure, why not.
@Darkmew can you finish this before Beta 2 ETA?

@Darkmew

This comment has been minimized.

Show comment
Hide comment
@Darkmew

Darkmew Jun 29, 2014

Probably won't make the ETA by tomorrow due to work constraints. Moving to beta3

Darkmew commented Jun 29, 2014

Probably won't make the ETA by tomorrow due to work constraints. Moving to beta3

@Darkmew Darkmew modified the milestones: 1.8 Beta 3, 1.8 Beta 2 Jun 29, 2014

@PirataNervo PirataNervo referenced this issue Jun 30, 2014

Closed

Forum Statistics Improvements v2 #824

1 of 1 task complete

@PirataNervo PirataNervo added the fixed label Jun 30, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 30, 2014

Contributor

Closing this. Caching will be resolved in Beta 3.

Contributor

PirataNervo commented Jun 30, 2014

Closing this. Caching will be resolved in Beta 3.

@PirataNervo PirataNervo modified the milestones: 1.8 Beta 2, 1.8 Beta 3 Jun 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment