-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal Improvements #436
Comments
I think: |
As always: Please use the forums for suggestions... |
@ATofighi is your PR finished? There are conflicts to be resolved. Let me know if you can get it fixed before the 30th of June. |
@ATofighi a setting to disable could be added since some features already have its own settings (calendar, member list, etc). I don't think anyone will oppose. |
See the comments here: #109 |
@ATofighi your PR has conflicts, please fix them so we can test this accordingly. Otherwise I'm forced to set this to Beta 3. |
@JordanMussi a setting to disable it and a link to it should be added. I have added both to the list here. @ATofighi I can't understand why a link is not added if so many people don't get to know there is a portal. Users will probably think the portal is a new feature after they see a link there :P! Haha. |
@JN-Jones @ImadJomaa @Polarbear541 @JordanMussi if someone could look at this, I'd definitely appreciate. |
@ATofighi is it finished? |
@PirataNervo Yes, I only work on Forum name in announcements. - Excluded forums from latest threads box. - Portal Feed - Setting to disable portal - Link on header - Portal Pagination but I don't have any idea for Post preview in latest threads box. |
I'm postponing this to Beta 3 as it has to be tested first and we don't have time to make it into Beta 2. Thanks @ATofighi |
I think "Post preview in latest threads box." can as well be dropped. TBH the box seems already fully functional, adding a excerpt of the first post will make it unnecessary complicated and I'm not sure if it will even be optimal to be worth it. Users like to install stats plug-ins anyways. Feel free to comment. @ATofighi please fix the issues in your PR so that it can be merged. Thank! |
"Excluded forums from latest threads box." is the last one missing. A setting to select which forums to query the latest threads from should be added. |
I think there's something wrong with the paging in the portal, let me see if I can fix it. |
Added setting to exclude forums from latest threads box. Also updated some setting descriptions.
I added the exclude forums from latest threads box setting. If there is nothing else, this can be considered finished. |
I think there's something wrong with the paging in the portal, yet. |
I'll look into that. By wrong, do you mean the pagination links are incorrect or something else? |
TID=10 shows at the beginning and at the end in place of TID=1 and TID=1 doesn't shows at all. All the threads shows mixed. |
I used MyDevel: Generate to generate the threads. After manually creating some the issue doesn't show. If you find the time to test yourself that would be great, otherwise it may have been the plug-in and this may as well be considered done. |
The following has been accepted:
Post preview in latest threads box.The text was updated successfully, but these errors were encountered: