Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal Improvements #436

Closed
Sama34 opened this issue Apr 28, 2014 · 20 comments
Closed

Portal Improvements #436

Sama34 opened this issue Apr 28, 2014 · 20 comments
Assignees
Milestone

Comments

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Apr 28, 2014

The following has been accepted:

  • Forum name in announcements.
  • Excluded forums from latest threads box.
  • Post preview in latest threads box.
  • Portal Feed
  • Portal Pagination
  • Setting to disable portal
  • Link on header
@Sama34 Sama34 added this to the 1.8 Beta 2 milestone Apr 28, 2014
@Sama34 Sama34 self-assigned this Apr 28, 2014
@Sama34 Sama34 changed the title Portal Permissions Portal Improvements May 18, 2014
@Sama34 Sama34 assigned PaulBender and unassigned Sama34 May 19, 2014
@ATofighi
Copy link
Contributor

@ATofighi ATofighi commented Jun 5, 2014

I think:
a setting for disable/enable portal

@JN-Jones
Copy link
Contributor

@JN-Jones JN-Jones commented Jun 5, 2014

As always: Please use the forums for suggestions...

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 27, 2014

@ATofighi is your PR finished? There are conflicts to be resolved. Let me know if you can get it fixed before the 30th of June.

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jun 28, 2014

@ATofighi a setting to disable could be added since some features already have its own settings (calendar, member list, etc).

I don't think anyone will oppose.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 29, 2014

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jun 29, 2014

I don't think anyone will oppose.

See the comments here: #109

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 29, 2014

@ATofighi your PR has conflicts, please fix them so we can test this accordingly. Otherwise I'm forced to set this to Beta 3.

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jun 29, 2014

@JordanMussi a setting to disable it and a link to it should be added. I have added both to the list here. @ATofighi

I can't understand why a link is not added if so many people don't get to know there is a portal. Users will probably think the portal is a new feature after they see a link there :P! Haha.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 29, 2014

@JN-Jones @ImadJomaa @Polarbear541 @JordanMussi if someone could look at this, I'd definitely appreciate.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 29, 2014

@ATofighi is it finished?

@ATofighi
Copy link
Contributor

@ATofighi ATofighi commented Jun 30, 2014

@PirataNervo Yes, I only work on Forum name in announcements. - Excluded forums from latest threads box. - Portal Feed - Setting to disable portal - Link on header - Portal Pagination but I don't have any idea for Post preview in latest threads box.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 30, 2014

I'm postponing this to Beta 3 as it has to be tested first and we don't have time to make it into Beta 2. Thanks @ATofighi

@DiogoParrinha DiogoParrinha modified the milestones: 1.8 Beta 3, 1.8 Beta 2 Jun 30, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 2, 2014

I think "Post preview in latest threads box." can as well be dropped. TBH the box seems already fully functional, adding a excerpt of the first post will make it unnecessary complicated and I'm not sure if it will even be optimal to be worth it. Users like to install stats plug-ins anyways.

Feel free to comment.

@ATofighi please fix the issues in your PR so that it can be merged. Thank!

Sama34 pushed a commit that referenced this issue Jul 2, 2014
Sama34 pushed a commit that referenced this issue Jul 2, 2014
@ATofighi ATofighi mentioned this issue Jul 3, 2014
Sama34 pushed a commit that referenced this issue Jul 3, 2014
Sama34 added a commit that referenced this issue Jul 8, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 8, 2014

"Excluded forums from latest threads box." is the last one missing. A setting to select which forums to query the latest threads from should be added.

PaulBender added a commit that referenced this issue Jul 9, 2014
Cached templates in portal.php
@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 9, 2014

I think there's something wrong with the paging in the portal, let me see if I can fix it.

PaulBender added a commit that referenced this issue Jul 9, 2014
Fixed multipage issues in portal
PaulBender added a commit that referenced this issue Jul 11, 2014
Added setting to exclude forums from latest threads box. Also updated some setting descriptions.
PaulBender added a commit that referenced this issue Jul 11, 2014
Setting had the wrong name >_<
@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 11, 2014

I added the exclude forums from latest threads box setting. If there is nothing else, this can be considered finished.

@PaulBender PaulBender added the fixed label Jul 11, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 14, 2014

I think there's something wrong with the paging in the portal, yet.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jul 16, 2014

I'll look into that. By wrong, do you mean the pagination links are incorrect or something else?

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 16, 2014

TID=10 shows at the beginning and at the end in place of TID=1 and TID=1 doesn't shows at all. All the threads shows mixed.

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 17, 2014

I used MyDevel: Generate to generate the threads. After manually creating some the issue doesn't show.

If you find the time to test yourself that would be great, otherwise it may have been the plug-in and this may as well be considered done.

@Sama34 Sama34 added the feedback label Jul 17, 2014
@Sama34 Sama34 closed this Jul 17, 2014
@JordanMussi JordanMussi removed the feedback label Jul 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.