-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moderate Groups #439
Comments
@Sama34 what is this exactly? The ability to create, edit and delete groups from the ModCP? |
No. Admins and Mods can moderate a user's posts and signature. This option allows administrators to moderate entire groups. |
I don't think I understand this feature to be honest with you. What do you mean by "moderate entire groups" ? I'm also unsure about what you mean by "moderator a user's signature". We can moderate new posts right now AFAIK (only). Do you want to be able to set a group to be moderated for X time as well? So new posts made by that group are unapproved at first? |
At the moment a moderator can edit a user and select an option to moderate that users posts (they are unapproved instantly when posted) or signature (requires approval before it becomes active). This option brings the possibility to move a user to a group where the administrator has set posts/signatures to be moderated. |
Ah alright sounds good to me then. |
Just as we currently moderate users posts/threads on a per-user base but for groups. I don't think adding a per-forum->per-group permission system to be necessary. |
Unsure if this was the original intention but now administrators can moderate users's posts/threads on a per-group basis just to how forums do it. I don't think we need to add a per-user option to moderate threads since moderating posts already does the job. What do you think? @mybb/developers |
Shouldn't there be options to moderate new attachments and moderate edited posts be added to the group permissions too? |
@PaulBender They already are. Aren't they? |
Only as a forum option. I was thinking, wouldn't it be easier if we removed the forum moderation options and make them completely group-based. You can add the moderation options to the forum permissions for Admins that want to control moderation per forum. |
So move them from forum -> group? And add them to the forums "Set Custom Permissions" section? Do you want to give it a try? I'm not that experienced with forum permissions and time is again us right now. You will need to revert my changes if so, I committed directly. Otherwise I will come back to this before the Beta 3 ETA reaches. The code is working as it currently is. |
Yeah, I'll give it a try. Should be easy. |
Done. |
@PaulBender After quick edit:
If it is the first post, shouldn't the user be redirected? |
Yes it should. |
@PaulBender |
Yeah, the forum options are gone. They have been moved to the forum permissions. |
in: i mean is: if you (removed the forum moderation options) we can use Moderation Options separately for any forum like now on MyBB 1.8 beta-2 ? or not ? |
They've been moved to the forum permissions. |
Ok then we can use them like now. |
@PaulBender may you update the code so that "Moderate new threads" moderate only first posts (threads) and "Moderate new posts" moderates only posts (replies)? In the upgrade script it should check if "Moderate new posts" is checked and mark both as checked if so. |
Done |
But the upgrade script should update the checked value (if it was checked before now both should be checked). Don't you think the same? |
Incorrect settings .. |
Fixed bug when editing group permission
That should fix it. |
I think you fixed this, am I right? There is no reference here. |
I never fixed it as I'm not sure how to (javascript is not my strong suit). |
I think that should fix the issue with moderators being redirected even when they can approve the post/thread/attachment. If so I will create a new bug issue for the JavaScript so this can be marked as closed. |
Reference: Moderate certain groups
The text was updated successfully, but these errors were encountered: