Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderate Groups #439

Closed
Sama34 opened this issue Apr 28, 2014 · 29 comments
Closed

Moderate Groups #439

Sama34 opened this issue Apr 28, 2014 · 29 comments
Assignees
Milestone

Comments

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Apr 28, 2014

  • Moderate new threads
  • Moderate new posts
  • Moderate new attachments
  • Moderate posts after they've been edited

Reference: Moderate certain groups

@Sama34 Sama34 added this to the 1.8 Beta 2 milestone Apr 28, 2014
@Sama34 Sama34 self-assigned this Apr 28, 2014
@Sama34 Sama34 assigned PaulBender and unassigned Sama34 May 19, 2014
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented May 20, 2014

@Sama34 what is this exactly? The ability to create, edit and delete groups from the ModCP?

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented May 20, 2014

No. Admins and Mods can moderate a user's posts and signature. This option allows administrators to moderate entire groups.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented May 20, 2014

I don't think I understand this feature to be honest with you. What do you mean by "moderate entire groups" ? I'm also unsure about what you mean by "moderator a user's signature". We can moderate new posts right now AFAIK (only). Do you want to be able to set a group to be moderated for X time as well? So new posts made by that group are unapproved at first?

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented May 20, 2014

At the moment a moderator can edit a user and select an option to moderate that users posts (they are unapproved instantly when posted) or signature (requires approval before it becomes active). This option brings the possibility to move a user to a group where the administrator has set posts/signatures to be moderated.
Time is also an option in the ModCP for the current functionality so I would assume yes but with my scenario then possibly not needed.
Example usage of this would be to have a group for newly registered users with this moderation on and be moved to a registered group without once they have posted quality posts that have been approved.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented May 20, 2014

Ah alright sounds good to me then.

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented May 25, 2014

Just as we currently moderate users posts/threads on a per-user base but for groups. I don't think adding a per-forum->per-group permission system to be necessary.

@DiogoParrinha DiogoParrinha modified the milestones: 1.8 Beta 3, 1.8 Beta 2 Jun 27, 2014
Sama34 pushed a commit that referenced this issue Jul 4, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 4, 2014

Unsure if this was the original intention but now administrators can moderate users's posts/threads on a per-group basis just to how forums do it.

I don't think we need to add a per-user option to moderate threads since moderating posts already does the job.

What do you think? @mybb/developers

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 4, 2014

Shouldn't there be options to moderate new attachments and moderate edited posts be added to the group permissions too?

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 7, 2014

moderate edited posts

@PaulBender They already are. Aren't they?

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 7, 2014

Only as a forum option.

I was thinking, wouldn't it be easier if we removed the forum moderation options and make them completely group-based. You can add the moderation options to the forum permissions for Admins that want to control moderation per forum.

@Sama34 Sama34 assigned Sama34 and unassigned PaulBender Jul 8, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 8, 2014

So move them from forum -> group? And add them to the forums "Set Custom Permissions" section?

Do you want to give it a try? I'm not that experienced with forum permissions and time is again us right now. You will need to revert my changes if so, I committed directly. Otherwise I will come back to this before the Beta 3 ETA reaches. The code is working as it currently is.

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 8, 2014

Yeah, I'll give it a try. Should be easy.

PaulBender added a commit that referenced this issue Jul 8, 2014
@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 8, 2014

Done.

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 9, 2014

@PaulBender After quick edit:

{"failed":"Your post is now under moderation."}

If it is the first post, shouldn't the user be redirected?

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 10, 2014

Yes it should.

@Sama34 Sama34 mentioned this issue Jul 10, 2014
3 of 3 tasks complete
@OMID-F
Copy link

@OMID-F OMID-F commented Jul 10, 2014

@PaulBender
about this: (I was thinking, wouldn't it be easier if we removed the forum moderation options and make them completely group-based)
if you do that, can we set limit on any forum we want like 1.6 or all gone ?
that options can be very necessary for some admins.
sorry if i misunderstood.

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 10, 2014

Yeah, the forum options are gone. They have been moved to the forum permissions.

@OMID-F
Copy link

@OMID-F OMID-F commented Jul 10, 2014

in:
Home » Forum Management » Edit Forum » Edit Forum Settings
We have::::
"Moderation Options
Yes, moderate new posts
Yes, moderate new threads
Yes, moderate new attachments
Yes, moderate posts after they've been edited"


i mean is: if you (removed the forum moderation options) we can use Moderation Options separately for any forum like now on MyBB 1.8 beta-2 ? or not ?
so if we can't use forum moderation options, separately on forums, our sites become useless :(
and (make them completely group-based) so in that case how we can create a forum that need to moderate new threads for everyone - any group ?
i thing (remove the forum moderation options) is bad idea.

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 10, 2014

They've been moved to the forum permissions.
Home » Forum Management » Edit Forum » Permissions » Set Custom Permissions » under the Moderation tab

@OMID-F
Copy link

@OMID-F OMID-F commented Jul 10, 2014

Ok then we can use them like now.

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 12, 2014

@PaulBender may you update the code so that "Moderate new threads" moderate only first posts (threads) and "Moderate new posts" moderates only posts (replies)?

In the upgrade script it should check if "Moderate new posts" is checked and mark both as checked if so.

PaulBender added a commit that referenced this issue Jul 12, 2014
Fixed permissions related to #351
@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 12, 2014

Done

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 12, 2014

But the upgrade script should update the checked value (if it was checked before now both should be checked). Don't you think the same?

@xykul
Copy link

@xykul xykul commented Jul 13, 2014

Incorrect settings ..
groups seem not registered.
Seems to be registered in your forum settings.
moderation, which is applied to the record.

PaulBender added a commit that referenced this issue Jul 13, 2014
Fixed bug when editing group permission
@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 13, 2014

That should fix it.

@xykul
Copy link

@xykul xykul commented Jul 13, 2014

Is this true for you?
Administrators group setting
admin
Administrators thread and message
forums

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 14, 2014

If it is the first post, shouldn't the user be redirected?

I think you fixed this, am I right? There is no reference here.

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 14, 2014

I never fixed it as I'm not sure how to (javascript is not my strong suit).

PaulBender added a commit that referenced this issue Jul 14, 2014
Forgot to drop old forum fields
Sama34 pushed a commit that referenced this issue Jul 19, 2014
Sama34 pushed a commit that referenced this issue Jul 19, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 19, 2014

I think that should fix the issue with moderators being redirected even when they can approve the post/thread/attachment.

If so I will create a new bug issue for the JavaScript so this can be marked as closed.

@Sama34 Sama34 closed this Jul 19, 2014
@Sama34 Sama34 added the fixed label Jul 19, 2014
@DiogoParrinha DiogoParrinha added feature and removed enhancement labels Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.