Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to [video] mycode #450

Closed
Starpaul20 opened this issue Apr 29, 2014 · 5 comments
Closed

Add to [video] mycode #450

Starpaul20 opened this issue Apr 29, 2014 · 5 comments
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@Starpaul20
Copy link
Member

Starpaul20 commented Apr 29, 2014

Add Facebook, Veoh and LiveLeak to [video] code

@Starpaul20 Starpaul20 added this to the 1.8 Beta 2 milestone Apr 29, 2014
@Starpaul20 Starpaul20 self-assigned this Apr 29, 2014
Starpaul20 added a commit that referenced this issue Jun 11, 2014
@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 11, 2014

This adds the new video sites to the video code itself. I'll be adding to the editor with my next commit.

Starpaul20 added a commit that referenced this issue Jun 11, 2014
Updated Liveleak's embed code
Added Veoh to editor
@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 11, 2014

This updated Liveleak's embed code and added Veoh to the editor (the other two are causing me problems).

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 23, 2014

@PaulBender which ones are causing you problems? Also, this was committed directly right? I think you forgot to add Liveleak to the Editor video dropdown. Same as Facebook.

If this was committed directly, it must be finished in time for Beta 2.

@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 23, 2014

Liveleak and Facebook won't render in the editor, that's why I didn't add them to the editor video dropdown. They work fine otherwise.

Yes, it committed directly.

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 23, 2014

Oh alright then. Any ideas why they won't render properly? I'm closing this by the way. We can fix this later if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

3 participants