/mybb

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Reason #451

Closed
PaulBender opened this Issue Apr 29, 2014 · 13 comments

Comments

Assignees

@PaulBender PaulBender

Labels
Projects
None yet
Milestone
  1.8 Beta 2
8 participants
@PaulBender @Stefan-ST @Eldenroot @Holyphoenix @PirataNervo @JordanMussi @ATofighi @PenguinPaul
@PaulBender
Member

PaulBender commented Apr 29, 2014

Allows a user to add an optional reason why they edited their post.

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Apr 29, 2014

@PaulBender PaulBender added enhancement labels Apr 29, 2014

@PaulBender PaulBender self-assigned this Apr 29, 2014

@Stefan-ST

This comment has been minimized.

Show comment
Hide comment
@Stefan-ST

Stefan-ST May 17, 2014

Contributor

@martec This is no poll or something like that... ;)
Contributor

Stefan-ST commented May 17, 2014

@martec This is no poll or something like that... ;)
@Eldenroot

This comment has been minimized.

Show comment
Hide comment
@Eldenroot

Eldenroot May 27, 2014

Contributor

+1 - there is a mod for mybb 1.4 - maybe you could use it and modified it to mybb1.8 - mod Edit reason
Contributor

Eldenroot commented May 27, 2014

+1 - there is a mod for mybb 1.4 - maybe you could use it and modified it to mybb1.8 - mod Edit reason
@Holyphoenix

This comment has been minimized.

Show comment
Hide comment
@Holyphoenix

Holyphoenix Jun 3, 2014

+1 from me. I have been dying for this feature. If it is added my excitement for Mybb 1.8 would increase 10 fold.

Holyphoenix commented Jun 3, 2014

+1 from me. I have been dying for this feature. If it is added my excitement for Mybb 1.8 would increase 10 fold.
@Stefan-ST

This comment has been minimized.

Show comment
Hide comment
@Stefan-ST

Stefan-ST Jun 3, 2014

Contributor

@Cu8eR @Holyphoenix Again, this is no poll...
Contributor

Stefan-ST commented Jun 3, 2014

@Cu8eR @Holyphoenix Again, this is no poll...
@Holyphoenix

This comment has been minimized.

Show comment
Hide comment
@Holyphoenix

Holyphoenix Jun 3, 2014

By no poll I am assuming you mean you don't need approval ratings from this item and it is already approved for entry?

Holyphoenix commented Jun 3, 2014

By no poll I am assuming you mean you don't need approval ratings from this item and it is already approved for entry?
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 3, 2014

Contributor

Yes, when we post an issue here it's because it will make into the specified milestone (or postponed to the next if we can't complete it by the release date).
Contributor

PirataNervo commented Jun 3, 2014

Yes, when we post an issue here it's because it will make into the specified milestone (or postponed to the next if we can't complete it by the release date).
@JordanMussi

This comment has been minimized.

Show comment
Hide comment
@JordanMussi

JordanMussi Jun 3, 2014

Contributor

By no poll he means there is no need for the +1s as it is already confirmed to be added to MyBB. 😄
Contributor

JordanMussi commented Jun 3, 2014

By no poll he means there is no need for the +1s as it is already confirmed to be added to MyBB. 😄
@ATofighi

This comment has been minimized.

Show comment
Hide comment
@ATofighi

ATofighi Jun 3, 2014

Contributor

I will create PR for this.
Contributor

ATofighi commented Jun 3, 2014

I will create PR for this.

@ATofighi ATofighi referenced this issue Jun 3, 2014

Merged

Fixes #451 Edit Reason #706

@PenguinPaul

This comment has been minimized.

Show comment
Hide comment
@PenguinPaul

PenguinPaul Jun 3, 2014

Contributor

Pull #706 looks good to me - should there be a box for edit reason on the quick edit as well?
Contributor

PenguinPaul commented Jun 3, 2014

Pull #706 looks good to me - should there be a box for edit reason on the quick edit as well?

PenguinPaul pushed a commit that referenced this issue Jun 3, 2014

Paul Hedman
Merge pull request #706 from ATofighi/edit-reason 
[1.8 PR] #451 - Edit Reason
a8bfd8e
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 3, 2014

Member

If one can be added, then yes.
Member

PaulBender commented Jun 3, 2014

If one can be added, then yes.

This was referenced Jun 4, 2014

Closed
Merged
@ATofighi

This comment has been minimized.

Show comment
Hide comment
@ATofighi

ATofighi Jun 4, 2014

Contributor

@PenguinPaul please see #717
Contributor

ATofighi commented Jun 4, 2014

@PenguinPaul please see #717

PenguinPaul pushed a commit that referenced this issue Jun 6, 2014

Paul Hedman
Merge pull request #717 from ATofighi/patch-24 
#451 - Edit reason 2
c842d9c

PaulBender added a commit that referenced this issue Jun 16, 2014

@PaulBender
Inproving #451 Edit Reason 
Just some minor work...
c35fd84
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 16, 2014

Member

I have made some improvements to the edit reason field. I added a setting to allow Admins to disable the edit reason field and made the field a little longer.

If there's no other problems, this can be marked as finished.
Member

PaulBender commented Jun 16, 2014

I have made some improvements to the edit reason field. I added a setting to allow Admins to disable the edit reason field and made the field a little longer.

If there's no other problems, this can be marked as finished.

@PaulBender PaulBender added the fixed label Jun 16, 2014

PaulBender added a commit that referenced this issue Jun 17, 2014

@PaulBender
Improving #451 Edit Reason 
Moved id out of if
d929a5f
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 19, 2014

Contributor

According to my tests it seemed to work fine. I'm closing this.
Contributor

PirataNervo commented Jun 19, 2014

According to my tests it seemed to work fine. I'm closing this.

@PirataNervo PirataNervo closed this Jun 19, 2014

@PirataNervo PirataNervo added feature and removed enhancement labels Jun 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment