Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Reason #451

Closed
PaulBender opened this issue Apr 29, 2014 · 13 comments
Closed

Edit Reason #451

PaulBender opened this issue Apr 29, 2014 · 13 comments
Assignees
Milestone

Comments

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Apr 29, 2014

Allows a user to add an optional reason why they edited their post.

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Apr 29, 2014
@PaulBender PaulBender self-assigned this Apr 29, 2014
@Stefan-ST
Copy link
Contributor

@Stefan-ST Stefan-ST commented May 17, 2014

@martec This is no poll or something like that... ;)

@Eldenroot
Copy link
Contributor

@Eldenroot Eldenroot commented May 27, 2014

+1 - there is a mod for mybb 1.4 - maybe you could use it and modified it to mybb1.8 - mod Edit reason

@Holyphoenix
Copy link

@Holyphoenix Holyphoenix commented Jun 3, 2014

+1 from me. I have been dying for this feature. If it is added my excitement for Mybb 1.8 would increase 10 fold.

@Stefan-ST
Copy link
Contributor

@Stefan-ST Stefan-ST commented Jun 3, 2014

@Cu8eR @Holyphoenix Again, this is no poll...

@Holyphoenix
Copy link

@Holyphoenix Holyphoenix commented Jun 3, 2014

By no poll I am assuming you mean you don't need approval ratings from this item and it is already approved for entry?

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 3, 2014

Yes, when we post an issue here it's because it will make into the specified milestone (or postponed to the next if we can't complete it by the release date).

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jun 3, 2014

By no poll he means there is no need for the +1s as it is already confirmed to be added to MyBB. 😄

@ATofighi
Copy link
Contributor

@ATofighi ATofighi commented Jun 3, 2014

I will create PR for this.

@PenguinPaul
Copy link
Contributor

@PenguinPaul PenguinPaul commented Jun 3, 2014

Pull #706 looks good to me - should there be a box for edit reason on the quick edit as well?

PenguinPaul pushed a commit that referenced this issue Jun 3, 2014
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 3, 2014

If one can be added, then yes.

This was referenced Jun 4, 2014
@ATofighi
Copy link
Contributor

@ATofighi ATofighi commented Jun 4, 2014

@PenguinPaul please see #717

PenguinPaul pushed a commit that referenced this issue Jun 6, 2014
PaulBender added a commit that referenced this issue Jun 16, 2014
Just some minor work...
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 16, 2014

I have made some improvements to the edit reason field. I added a setting to allow Admins to disable the edit reason field and made the field a little longer.

If there's no other problems, this can be marked as finished.

@PaulBender PaulBender added the fixed label Jun 16, 2014
PaulBender added a commit that referenced this issue Jun 17, 2014
Moved id out of if
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 19, 2014

According to my tests it seemed to work fine. I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.