New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contact fields #455
Comments
?? |
@martec, those are still active enough to not to be removed. |
and this? Improvements to custom profile fields in profile; hide if none? |
MSN Messenger has been removed; Skype and Google Talk have been added
This has been finished |
MSN Messenger has been removed; Skype and Google Talk have been added
@martec, that may be added at a later point. |
what? may? You're saying can be added, but has the possibility of not being added in mybb 1.8? |
@martec I can't speak for Omar, but I don't think he realized you were quoting from the thread (General Improvements section). In any event the section does have an appended question mark ? so we'll have to wait for one of our leaders to verify whether it is marked for 1.8. I personally don't see why it wouldn't be. |
thanks... |
@martec The maximum votes per user feature isn't part of that issue. |
@PaulBender |
@PaulBender committed directly or PR? |
I committed directly |
Google Talk is now Hangouts. |
@PaulBender I see the following code: "aim" => $db->escape_string(htmlspecialchars($user['aim'])),
"yahoo" => $db->escape_string(htmlspecialchars($user['yahoo'])),
"skype" => $db->escape_string(htmlspecialchars($user['skype'])),
"google" => $db->escape_string(htmlspecialchars($user['google'])), You should save the raw data to the DB. I know you are following how it was done but since you are adding two new fields you should add them the right way. Unsure if the remaining ones will get a fix. |
+1 @Sama34. Keep the original data in the DB, escape on output. Might as well fix the other fields while you're there too if they have an issue. |
@euantorano current fields need special handling. See internal thread: http://community.mybb.com/thread-153319.html |
The text was updated successfully, but these errors were encountered: