New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact fields #455

Closed
PaulBender opened this Issue Apr 29, 2014 · 16 comments

Comments

Projects
None yet
8 participants
@PaulBender
Member

PaulBender commented Apr 29, 2014

  • MSN Messenger doesn't exist anymore and should be removed.
  • Skype and Google Talk should be added.

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Apr 29, 2014

@PaulBender PaulBender self-assigned this Apr 29, 2014

@martec

This comment has been minimized.

Show comment
Hide comment
@martec

martec May 17, 2014

Contributor

??
will keep ICQ, AIM and Yahoo?
personally should be removed also.

Contributor

martec commented May 17, 2014

??
will keep ICQ, AIM and Yahoo?
personally should be removed also.

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 May 17, 2014

Contributor

@martec, those are still active enough to not to be removed.

Contributor

Sama34 commented May 17, 2014

@martec, those are still active enough to not to be removed.

@martec

This comment has been minimized.

Show comment
Hide comment
@martec

martec May 22, 2014

Contributor

and this?

Improvements to custom profile fields in profile; hide if none?

http://community.mybb.com/thread-149158.html

Contributor

martec commented May 22, 2014

and this?

Improvements to custom profile fields in profile; hide if none?

http://community.mybb.com/thread-149158.html

@PaulBender PaulBender modified the milestones: 1.8 Beta 1, 1.8 Beta 2 May 22, 2014

PaulBender added a commit that referenced this issue May 22, 2014

Feature #455 Update contact fields
MSN Messenger has been removed; Skype and Google Talk have been added
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 22, 2014

Member

This has been finished

Member

PaulBender commented May 22, 2014

This has been finished

JordanMussi added a commit to JordanMussi/MyBB that referenced this issue May 24, 2014

Feature #455 Update contact fields
MSN Messenger has been removed; Skype and Google Talk have been added

@JordanMussi JordanMussi added the fixed label May 24, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 May 25, 2014

Contributor

@martec, that may be added at a later point.

Contributor

Sama34 commented May 25, 2014

@martec, that may be added at a later point.

@martec

This comment has been minimized.

Show comment
Hide comment
@martec

martec May 27, 2014

Contributor

@Sama34

what? may? You're saying can be added, but has the possibility of not being added in mybb 1.8?
http://community.mybb.com/thread-149158.html this link does not confirmed features?
This means that other confirmed features can also be ignored?

Contributor

martec commented May 27, 2014

@Sama34

what? may? You're saying can be added, but has the possibility of not being added in mybb 1.8?
http://community.mybb.com/thread-149158.html this link does not confirmed features?
This means that other confirmed features can also be ignored?

@WildcardSearch

This comment has been minimized.

Show comment
Hide comment
@WildcardSearch

WildcardSearch May 27, 2014

Member

@martec I can't speak for Omar, but I don't think he realized you were quoting from the thread (General Improvements section).

In any event the section does have an appended question mark ? so we'll have to wait for one of our leaders to verify whether it is marked for 1.8. I personally don't see why it wouldn't be.

Member

WildcardSearch commented May 27, 2014

@martec I can't speak for Omar, but I don't think he realized you were quoting from the thread (General Improvements section).

In any event the section does have an appended question mark ? so we'll have to wait for one of our leaders to verify whether it is marked for 1.8. I personally don't see why it wouldn't be.

@martec

This comment has been minimized.

Show comment
Hide comment
@martec

martec May 27, 2014

Contributor

@WildcardSearch

thanks...
I'll be waiting for the verifying ..

Contributor

martec commented May 27, 2014

@WildcardSearch

thanks...
I'll be waiting for the verifying ..

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 27, 2014

Member

@martec The maximum votes per user feature isn't part of that issue.

Member

PaulBender commented May 27, 2014

@martec The maximum votes per user feature isn't part of that issue.

@martec

This comment has been minimized.

Show comment
Hide comment
@martec

martec May 27, 2014

Contributor

@PaulBender
sorry of off-topic...
i edit message...

Contributor

martec commented May 27, 2014

@PaulBender
sorry of off-topic...
i edit message...

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 27, 2014

Contributor

@PaulBender committed directly or PR?

Contributor

PirataNervo commented May 27, 2014

@PaulBender committed directly or PR?

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 27, 2014

Member

I committed directly

Member

PaulBender commented May 27, 2014

I committed directly

@VictorAtPL

This comment has been minimized.

Show comment
Hide comment
@VictorAtPL

VictorAtPL Jun 1, 2014

Google Talk is now Hangouts.

VictorAtPL commented Jun 1, 2014

Google Talk is now Hangouts.

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jul 7, 2014

Contributor

@PaulBender I see the following code:

            "aim" => $db->escape_string(htmlspecialchars($user['aim'])),
            "yahoo" => $db->escape_string(htmlspecialchars($user['yahoo'])),
            "skype" => $db->escape_string(htmlspecialchars($user['skype'])),
            "google" => $db->escape_string(htmlspecialchars($user['google'])),

You should save the raw data to the DB. I know you are following how it was done but since you are adding two new fields you should add them the right way. Unsure if the remaining ones will get a fix.

Contributor

Sama34 commented Jul 7, 2014

@PaulBender I see the following code:

            "aim" => $db->escape_string(htmlspecialchars($user['aim'])),
            "yahoo" => $db->escape_string(htmlspecialchars($user['yahoo'])),
            "skype" => $db->escape_string(htmlspecialchars($user['skype'])),
            "google" => $db->escape_string(htmlspecialchars($user['google'])),

You should save the raw data to the DB. I know you are following how it was done but since you are adding two new fields you should add them the right way. Unsure if the remaining ones will get a fix.

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 7, 2014

Member

+1 @Sama34. Keep the original data in the DB, escape on output. Might as well fix the other fields while you're there too if they have an issue.

Member

euantorano commented Jul 7, 2014

+1 @Sama34. Keep the original data in the DB, escape on output. Might as well fix the other fields while you're there too if they have an issue.

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jul 7, 2014

Contributor

@euantorano current fields need special handling.

See internal thread: http://community.mybb.com/thread-153319.html

Contributor

Sama34 commented Jul 7, 2014

@euantorano current fields need special handling.

See internal thread: http://community.mybb.com/thread-153319.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment