Update contact fields

[Starpaul20]

• MSN Messenger doesn't exist anymore and should be removed.
• Skype and Google Talk should be added.

[martec]

??
will keep ICQ, AIM and Yahoo?
personally should be removed also.

[Sama34]

@martec, those are still active enough to not to be removed.

[martec]

and this?

Improvements to custom profile fields in profile; hide if none?

http://community.mybb.com/thread-149158.html

[Starpaul20]

This has been finished

[Sama34]

@martec, that may be added at a later point.

[martec]

@Sama34

what? may? You're saying can be added, but has the possibility of not being added in mybb 1.8?
http://community.mybb.com/thread-149158.html this link does not confirmed features?
This means that other confirmed features can also be ignored?

[WildcardSearch]

@martec I can't speak for Omar, but I don't think he realized you were quoting from the thread (General Improvements section).

In any event the section does have an appended question mark ? so we'll have to wait for one of our leaders to verify whether it is marked for 1.8. I personally don't see why it wouldn't be.

[martec]

@WildcardSearch

thanks...
I'll be waiting for the verifying ..

[Starpaul20]

@martec The maximum votes per user feature isn't part of that issue.

[martec]

@PaulBender
sorry of off-topic...
i edit message...

[DiogoParrinha]

@PaulBender committed directly or PR?

[Starpaul20]

I committed directly

[VictorAtPL]

Google Talk is now Hangouts.

[Sama34]

@PaulBender I see the following code:

            "aim" => $db->escape_string(htmlspecialchars($user['aim'])),
            "yahoo" => $db->escape_string(htmlspecialchars($user['yahoo'])),
            "skype" => $db->escape_string(htmlspecialchars($user['skype'])),
            "google" => $db->escape_string(htmlspecialchars($user['google'])),

You should save the raw data to the DB. I know you are following how it was done but since you are adding two new fields you should add them the right way. Unsure if the remaining ones will get a fix.

[euantorano]

+1 @Sama34. Keep the original data in the DB, escape on output. Might as well fix the other fields while you're there too if they have an issue.

[Sama34]

@euantorano current fields need special handling.

See internal thread: http://community.mybb.com/thread-153319.html