Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact fields #455

Closed
Starpaul20 opened this issue Apr 29, 2014 · 16 comments
Closed

Update contact fields #455

Starpaul20 opened this issue Apr 29, 2014 · 16 comments
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@Starpaul20
Copy link
Member

  • MSN Messenger doesn't exist anymore and should be removed.
  • Skype and Google Talk should be added.
@Starpaul20 Starpaul20 added this to the 1.8 Beta 2 milestone Apr 29, 2014
@Starpaul20 Starpaul20 self-assigned this Apr 29, 2014
@martec
Copy link
Contributor

martec commented May 17, 2014

??
will keep ICQ, AIM and Yahoo?
personally should be removed also.

@Sama34
Copy link
Contributor

Sama34 commented May 17, 2014

@martec, those are still active enough to not to be removed.

@martec
Copy link
Contributor

martec commented May 22, 2014

and this?

Improvements to custom profile fields in profile; hide if none?

http://community.mybb.com/thread-149158.html

@Starpaul20 Starpaul20 modified the milestones: 1.8 Beta 1, 1.8 Beta 2 May 22, 2014
Starpaul20 added a commit that referenced this issue May 22, 2014
MSN Messenger has been removed; Skype and Google Talk have been added
@Starpaul20
Copy link
Member Author

This has been finished

JordanMussi pushed a commit to JordanMussi/MyBB that referenced this issue May 24, 2014
MSN Messenger has been removed; Skype and Google Talk have been added
@Sama34
Copy link
Contributor

Sama34 commented May 25, 2014

@martec, that may be added at a later point.

@martec
Copy link
Contributor

martec commented May 27, 2014

@Sama34

what? may? You're saying can be added, but has the possibility of not being added in mybb 1.8?
http://community.mybb.com/thread-149158.html this link does not confirmed features?
This means that other confirmed features can also be ignored?

@WildcardSearch
Copy link
Contributor

@martec I can't speak for Omar, but I don't think he realized you were quoting from the thread (General Improvements section).

In any event the section does have an appended question mark ? so we'll have to wait for one of our leaders to verify whether it is marked for 1.8. I personally don't see why it wouldn't be.

@martec
Copy link
Contributor

martec commented May 27, 2014

@WildcardSearch

thanks...
I'll be waiting for the verifying ..

@Starpaul20
Copy link
Member Author

@martec The maximum votes per user feature isn't part of that issue.

@martec
Copy link
Contributor

martec commented May 27, 2014

@PaulBender
sorry of off-topic...
i edit message...

@DiogoParrinha
Copy link
Contributor

@PaulBender committed directly or PR?

@Starpaul20
Copy link
Member Author

I committed directly

@VictorAtPL
Copy link

Google Talk is now Hangouts.

@Sama34
Copy link
Contributor

Sama34 commented Jul 7, 2014

@PaulBender I see the following code:

            "aim" => $db->escape_string(htmlspecialchars($user['aim'])),
            "yahoo" => $db->escape_string(htmlspecialchars($user['yahoo'])),
            "skype" => $db->escape_string(htmlspecialchars($user['skype'])),
            "google" => $db->escape_string(htmlspecialchars($user['google'])),

You should save the raw data to the DB. I know you are following how it was done but since you are adding two new fields you should add them the right way. Unsure if the remaining ones will get a fix.

@euantorano
Copy link
Member

+1 @Sama34. Keep the original data in the DB, escape on output. Might as well fix the other fields while you're there too if they have an issue.

@Sama34
Copy link
Contributor

Sama34 commented Jul 7, 2014

@euantorano current fields need special handling.

See internal thread: http://community.mybb.com/thread-153319.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

8 participants