Convert intval to typecast int

[DiogoParrinha]

Speed Tests Reference:
http://hakre.wordpress.com/2010/05/13/php-casting-vs-intval/

The speed increase is incredible and since we have a lot of intval's, I decided to write a script to help me out.

PHP Script:
http://pastebin.com/Qjfk1WEh

Usage: intval.php?dir=[PATH]

[darksonic37]

Does the speed increase apply to strval($foo) vs (string)$foo as well?

strval() occurs in captcha.php. Even if it's not faster, typecasting should still be preferred for some consistency.

Actually, is strval() even needed there?

[darksonic37]

There is also a bunch of occurrences for floatval().

[DiogoParrinha]

We need to do the replacement for floatval too but the amount of occurrences is much lower. As for the captcha, shouldn't be needed to replace by anything.

[darksonic37]

There is a strval() in captcha.php. Why not typecast there instead? It's a tiny detail but... :P

[JordanMussi]

For consistency, yes it should be changed to a typecast. 👅

[DiogoParrinha]

I just think that we should focus on important things rather than tiny details right now, but I guess that's just me.

[JN-Jones]

Not only ;) we can change this in a few seconds before we release beta 1, 2 or even before the final release - we should finish the jQuery conversion and release beta 1 ASAP

[darksonic37]

I was just pointing it out. I didn't see this mentioned before.

On Fri, May 9, 2014 at 8:16 PM, Jones notifications@github.com wrote:

Not only ;) we can change this in a few seconds before we release beta 1, 2 or even before the final release - we should finish the jQuery conversion and release beta 1 ASAP

Reply to this email directly or view it on GitHub:
#491 (comment)

[Sama34]

We can push this on Beta 1 and leave the rest of possible type-casting for beta 2. Who is the one to apply this? IIRC there were no issues on the tests done.

[DiogoParrinha]

I can do this, not a problem. But I'll only be able to look at this Thursday - though I believe there's no rush. We still have jQuery to complete.

[Stefan-MyBB]

Do it as late as possible, it may break pull requests and other stuff.

[DiogoParrinha]

Stefan is right, we should do this only when we're about to release Beta 1.

[PenguinPaul]

Looks like Beta 2 then?

[JordanMussi]

Yeah 👅 looks like we forgot this one...

[DiogoParrinha]

I didn't forget it - we can't risk losing PR compatibility until a few days before Beta 2 is ready. I postponed it to Beta 2.

[WildcardSearch]

I am of the opinion that this should be one of the last changes made before final testing. As mentioned it will effect almost every active PR so it would be best to finish all open issues (are as many as are feasible) before making this change.

[DiogoParrinha]

Postponing to Beta 3.

[Sama34]

@PirataNervo remember this is to be pushed at the last moment, we should get all enhancements and PRs done by then.

[DiogoParrinha]

@Sama34 yeap I remember :)

[DiogoParrinha]

This is finished.

[JordanMussi]

Before: $pms = implode(",", array_map("intval", $pms));
After: $pms = implode(",", array_map("(int), $pms); - missing " and you can't array_map using a cast either...
Should be (how it started): $pms = implode(",", array_map("intval", $pms);
https://github.com/mybb/mybb/blob/feature/moderation.php#L2791

We need to find more occurrences of this... (if there are any)

[euantorano]

Nice catch Jordan!

[JordanMussi]

Right, there are more locations.

Here's the list of all of them...

• admin/modules/forum/attachments.php
  • Line 247
  • Line 247
• admin/modules/forum/moderation_queue.php
  • Line 52
  • Line 90
  • Line 127
• admin/modules/style/templates.php
  • Line 27
• admin/modules/style/themes.php
  • Line 2541
• admin/modules/tools/mailerrors.php
  • Line 40
• admin/modules/tools/maillogs.php
  • Line 40
• inc/class_custommoderation.php
  • Line 130
• inc/functions_search.php
  • Line 634
• modcp.php
  • Line 303
  • Line 1894
  • Line 1942
  • Line 1990
• moderation.php
  • Line 2791
  • Line 2808

---

Some array_map('intval')s are unaffected. It must have been an odd issue in the converter...

[DiogoParrinha]

Yes the converted skipped array_maps. But I'll fix those manually now. Thanks Jordan.
EDIT: Ah the converted looked for ' and not " in array_map. It should have looked for both.

[DiogoParrinha]

@JordanMussi I think some of those locations are not right. I guess you probably just searched array_map rather than array_map("(int)

I've fixed 16 occurrences, going to commit now.

[DiogoParrinha]

I think this can be closed now.

[Starpaul20]

There are still some PHP parse errors. The array_map functions in 12096ed are all missing a closing parentheses ( ) ).

[DiogoParrinha]

Oops, forgot the converter did that too. Fixed that and the (int)(int) found in one file.

[DiogoParrinha]

I've gone through many many pages and didn't find any parse errors related to this, so I'm closing this issue.