Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Help Files #497

Closed
PaulBender opened this issue May 8, 2014 · 10 comments
Closed

Search Help Files #497

PaulBender opened this issue May 8, 2014 · 10 comments
Assignees
Milestone

Comments

@PaulBender
Copy link
Member

@PaulBender PaulBender commented May 8, 2014

Allow users to ability to search though the Help Files.

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone May 8, 2014
@PaulBender PaulBender self-assigned this May 8, 2014
PaulBender added a commit that referenced this issue Jun 5, 2014
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 5, 2014

This is finished

@PaulBender PaulBender added the feedback label Jun 5, 2014
@ATofighi
Copy link
Contributor

@ATofighi ATofighi commented Jun 5, 2014

I search "MyCode" in the Help,
I see html tags (like < p >) in search result but i think it should remove in it.

and highlight don't work. for search in help docs :(

@xykul
Copy link

@xykul xykul commented Jun 5, 2014

Not from the forum, doing database searches. Search is not in the language file is not useful.

@PaulBender PaulBender added fixed and removed feedback labels Jun 10, 2014
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 19, 2014

@PaulBender please fix this.

PaulBender added a commit that referenced this issue Jun 19, 2014
Fixes HTML appearing in search results
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 19, 2014

This fixes the HTML tags appearing in search results. There is no way unfortunately to fix the highlighting problem when using translation.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

@PaulBender HTML seems fixed :) Highlighting is not working for not-translated files though.

@DiogoParrinha DiogoParrinha removed the fixed label Jun 24, 2014
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 25, 2014

I don't know of any way of highlighting search results that are from the translation files (unless we abandon the help file translation system altogether).

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 25, 2014

I'm not sure if I follow you. I don't know much about the help files feature but when I add or edit a help document, I can write the content - is it put into the language files? That looks like that's what you're implying. Still, I don't know much about it and I guess you know more than me here as you've worked on it.

@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 25, 2014

No, when you add a help document, it's just inserted into the helpdocs table. The translation feature only exists for the default help docs.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 25, 2014

Ah, just let it be then. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.