Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPTCHA Improvements #557

Closed
DiogoParrinha opened this issue May 27, 2014 · 17 comments
Closed

CAPTCHA Improvements #557

DiogoParrinha opened this issue May 27, 2014 · 17 comments
Assignees
Milestone

Comments

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented May 27, 2014

  • Q&A Challenge

Original issue on 1.8 private repo: https://github.com/mybb/MyBB18/issues/21
What needs to be done: check if it's been finished or not.

To quote:

Clean up the reCAPTCHA integration; should we use reCAPTCHA by default and only use the MyBB default CAPTCHA if reC isn't available?

Should we introduce a Q&A challenge too? I'd quite like to see that.

@DiogoParrinha DiogoParrinha added this to the 1.8 Beta 1 milestone May 27, 2014
@PaulBender
Copy link
Member

@PaulBender PaulBender commented May 27, 2014

I'd love a Q&A challenge, as long as it's kept separate of CAPTCHA (I'd like to have both a CAPTCHA and a Q&A challenge).

@DiogoParrinha DiogoParrinha modified the milestones: 1.8 Beta 2, 1.8 Beta 1 May 27, 2014
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented May 27, 2014

I'm moving this to Beta 2.

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jun 2, 2014

Are we aiming to integrate Registration Security Question? I think this could be interesting.

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jun 2, 2014

We should also allow the admin to have multiple at the same time. e.g. reCAPTCHA and Are You A Human. Thus instead of a drop down selection we should use a checkbox list.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 2, 2014

@JordanMussi I'm against it. It involves too much work and I personally don't see that as a need. There are many other enhancements where we already have to put quite some work into.

@WildcardSearch
Copy link
Member

@WildcardSearch WildcardSearch commented Jun 2, 2014

I agree. That would be a complex addition fraught with the possibility of future conflicts.

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jun 2, 2014

Fair enough... It can be a new feature for 1.10 😉

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jun 5, 2014

1.10?

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jun 5, 2014

It's a joke, we will clearly be evil and announce 1.10 and delay 2.0 again 😉
1.10 will be the bridge between the bridge between 1.6 and 2.0 and 2.0... 👅

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jun 23, 2014

Q&A Challenge is done.

I based it upon the Registration Security Question plugin, minus the javascript (which I'm terrible at).

The pull request is here: #771

@DiogoParrinha DiogoParrinha modified the milestones: 1.8 Beta 3, 1.8 Beta 2 Jun 24, 2014
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

@PaulBender your PR has conflicts, I'd love to see this included in Beta 2 already as it only needs testing. Also what do you mean by "minus the javascript" ?

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jun 24, 2014

I screwed up when merging my old request so I deleted it and resubmitted it: #777

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jun 24, 2014

What I meant by the "minus the javascript" part is the Registration Security Question plugin has javascript validation of the answer along with the ability to refresh and get a new question.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

Oh I see, I guess I'll have to add that in Beta 3 (if people complain).

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jun 26, 2014

Screwed up again merging, had to resubmit: #794

DiogoParrinha pushed a commit that referenced this issue Jun 29, 2014
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 29, 2014

Merged PR. Waiting for feedback now.

@DiogoParrinha DiogoParrinha changed the title CAPTCHA Options CAPTCHA Improvements Jun 29, 2014
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 30, 2014

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.