Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicly shown poll end date #587

Closed
Polarbear541 opened this issue May 27, 2014 · 17 comments
Closed

Publicly shown poll end date #587

Polarbear541 opened this issue May 27, 2014 · 17 comments
Assignees
Milestone

Comments

@Polarbear541
Copy link
Contributor

@Polarbear541 Polarbear541 commented May 27, 2014

Add an option to show the poll end date publicly.

@Polarbear541 Polarbear541 self-assigned this May 27, 2014
@Polarbear541 Polarbear541 added this to the 1.8 Beta 2 milestone May 28, 2014
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 27, 2014

@Polarbear541 any updates here?

@Polarbear541
Copy link
Contributor Author

@Polarbear541 Polarbear541 commented Jun 28, 2014

Yep, should be done now :P

@DiogoParrinha DiogoParrinha added the fixed label Jun 28, 2014
DiogoParrinha pushed a commit that referenced this issue Jun 29, 2014
Feature #587 Publicly shown poll end date
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 29, 2014

Merged PR, closing this.

@martec
Copy link
Contributor

@martec martec commented Aug 1, 2014

@Polarbear541 @PirataNervo
??
for me not work...
and i can´t find any part of code of this PR in feature branche...
try find $closeon https://github.com/mybb/mybb/pull/806/files#diff-7e30b0b016de305a3f054a785bc62fb6R584 in showthread https://raw.githubusercontent.com/mybb/mybb/feature/showthread.php , not find anything

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Aug 1, 2014

This seems to have been removed in:
bcf7193#diff-7e30b0b016de305a3f054a785bc62fb6

@Sama34 this is kinda urgent, not sure if other features were erased too.

@DiogoParrinha DiogoParrinha reopened this Aug 1, 2014
@martec
Copy link
Contributor

@martec martec commented Aug 1, 2014

seriously?
it will take a hell of a headache and work.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Aug 1, 2014

@martec yeap

@Destroy666x
Copy link
Contributor

@Destroy666x Destroy666x commented Aug 1, 2014

Well, mistakes happen... And that's why PRs are much better @ internal discussion, good we started to use them.

@Stefan-ST
Copy link
Contributor

@Stefan-ST Stefan-ST commented Aug 1, 2014

@PirataNervo @Destroy666x @Sama34 This is the PR: #822 From looking over the changes it seams not to remove anything else beside this.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Aug 2, 2014

@Stefan-ST questions tables were also removed but they seem to have been added back after that PR.

@Stefan-ST
Copy link
Contributor

@Stefan-ST Stefan-ST commented Aug 2, 2014

@PirataNervo Neither #810, #821 nor #822 shows something related to questions in the diff report?

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Aug 2, 2014

@Stefan-ST I'm actually talking about this commit here: bcf7193#diff-7e30b0b016de305a3f054a785bc62fb6 Not sure why it shows like that in the commit but doesn't show in the PR. Still, if this is the only thing that needs correcting, it's not too bad. @Sama34

@Polarbear541
Copy link
Contributor Author

@Polarbear541 Polarbear541 commented Aug 2, 2014

There you go :)

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Aug 3, 2014

Guh, will check this ASAP.

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Aug 4, 2014

Right, missed @Polarbear541's PR. Hope is the only issue.

BTW @Polarbear541 I unassigned all of your issues, hope you don't mind.

PaulBender added a commit that referenced this issue Aug 6, 2014
@JN-Jones
Copy link
Contributor

@JN-Jones JN-Jones commented Sep 14, 2014

Was this fixed?

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Sep 14, 2014

I think it was.

@Sama34 Sama34 closed this Sep 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.