Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Default MyCodes #686

Closed
Starpaul20 opened this issue Jun 2, 2014 · 15 comments
Closed

Disable Default MyCodes #686

Starpaul20 opened this issue Jun 2, 2014 · 15 comments
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@Starpaul20
Copy link
Member

Add the ability to disable the default MyCodes.

@Starpaul20 Starpaul20 added this to the 1.8 Beta 2 milestone Jun 2, 2014
@Starpaul20 Starpaul20 self-assigned this Jun 2, 2014
@ATofighi
Copy link
Contributor

ATofighi commented Jun 3, 2014

I think it should append in Posting settings.

@Starpaul20
Copy link
Member Author

I finished the main enhancement (disabling default MyCodes).

One question, should I remove the editor icon if its MyCode is disabled?

@iangcarroll
Copy link

Looks good!

@iangcarroll
Copy link

@PaulBender Yeah

Starpaul20 added a commit that referenced this issue Jun 11, 2014
Remove buttons from editor if MyCode is disabled
@Starpaul20
Copy link
Member Author

The button will no longer appear on the editor if the MyCode is disabled.

This is now finished.

@Starpaul20 Starpaul20 added fixed and removed feedback labels Jun 11, 2014
@xykul
Copy link

xykul commented Jun 13, 2014

Allow Symbol mycodes
Select No and you receive the error
smilies

Starpaul20 added a commit that referenced this issue Jun 13, 2014
@Starpaul20
Copy link
Member Author

That should fix it.

@DiogoParrinha
Copy link
Contributor

@PaulBender please describe the feature - I can't seem to understand what this is and how to test it.

@Starpaul20
Copy link
Member Author

It simply disables the default MyCodes (like bold, color, size, etc). When you disable a MyCode, it should stop being parsed everywhere.

@JordanMussi
Copy link
Contributor

I'm not sure if there should be a tab in the Configuration -> MyCode module to point to the setting group...

@Sama34
Copy link
Contributor

Sama34 commented Jun 22, 2014

Shouldn't 'clickablecode' and 'mycode' setting groups be merged.

@DiogoParrinha
Copy link
Contributor

@PaulBender I agree with @Sama34. The Clickable + BB Code group has 4 settings. The MyCode settings should be in there. Besides that, this seems to work fine :)

@Starpaul20
Copy link
Member Author

I can merge them.

@DiogoParrinha
Copy link
Contributor

That would be good so we can close this.

Starpaul20 added a commit that referenced this issue Jun 24, 2014
Merged setting groups
@Starpaul20
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

7 participants