Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Default MyCodes #686

Closed
PaulBender opened this issue Jun 2, 2014 · 15 comments
Closed

Disable Default MyCodes #686

PaulBender opened this issue Jun 2, 2014 · 15 comments
Assignees
Milestone

Comments

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jun 2, 2014

Add the ability to disable the default MyCodes.

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Jun 2, 2014
@PaulBender PaulBender self-assigned this Jun 2, 2014
@ATofighi
Copy link
Contributor

@ATofighi ATofighi commented Jun 3, 2014

I think it should append in Posting settings.

PaulBender added a commit that referenced this issue Jun 10, 2014
@PaulBender PaulBender added the feedback label Jun 10, 2014
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 10, 2014

I finished the main enhancement (disabling default MyCodes).

One question, should I remove the editor icon if its MyCode is disabled?

@iangcarroll
Copy link

@iangcarroll iangcarroll commented Jun 10, 2014

Looks good!

@iangcarroll
Copy link

@iangcarroll iangcarroll commented Jun 10, 2014

PaulBender added a commit that referenced this issue Jun 11, 2014
Remove buttons from editor if MyCode is disabled
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 11, 2014

The button will no longer appear on the editor if the MyCode is disabled.

This is now finished.

@PaulBender PaulBender added fixed and removed feedback labels Jun 11, 2014
@xykul
Copy link

@xykul xykul commented Jun 13, 2014

Allow Symbol mycodes
Select No and you receive the error
smilies

PaulBender added a commit that referenced this issue Jun 13, 2014
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 13, 2014

That should fix it.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 19, 2014

@PaulBender please describe the feature - I can't seem to understand what this is and how to test it.

@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 19, 2014

It simply disables the default MyCodes (like bold, color, size, etc). When you disable a MyCode, it should stop being parsed everywhere.

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jun 20, 2014

I'm not sure if there should be a tab in the Configuration -> MyCode module to point to the setting group...

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jun 22, 2014

Shouldn't 'clickablecode' and 'mycode' setting groups be merged.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 23, 2014

@PaulBender I agree with @Sama34. The Clickable + BB Code group has 4 settings. The MyCode settings should be in there. Besides that, this seems to work fine :)

@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 24, 2014

I can merge them.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

That would be good so we can close this.

PaulBender added a commit that referenced this issue Jun 24, 2014
Merged setting groups
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 24, 2014

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.