New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Default MyCodes #686

Closed
PaulBender opened this Issue Jun 2, 2014 · 15 comments

Comments

Projects
None yet
7 participants
@PaulBender
Member

PaulBender commented Jun 2, 2014

Add the ability to disable the default MyCodes.

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Jun 2, 2014

@PaulBender PaulBender self-assigned this Jun 2, 2014

@ATofighi

This comment has been minimized.

Show comment
Hide comment
@ATofighi

ATofighi Jun 3, 2014

Contributor

I think it should append in Posting settings.

Contributor

ATofighi commented Jun 3, 2014

I think it should append in Posting settings.

PaulBender added a commit that referenced this issue Jun 10, 2014

@PaulBender PaulBender added the feedback label Jun 10, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 10, 2014

Member

I finished the main enhancement (disabling default MyCodes).

One question, should I remove the editor icon if its MyCode is disabled?

Member

PaulBender commented Jun 10, 2014

I finished the main enhancement (disabling default MyCodes).

One question, should I remove the editor icon if its MyCode is disabled?

@iangcarroll

This comment has been minimized.

Show comment
Hide comment
@iangcarroll

iangcarroll commented Jun 10, 2014

Looks good!

@iangcarroll

This comment has been minimized.

Show comment
Hide comment

iangcarroll commented Jun 10, 2014

PaulBender added a commit that referenced this issue Jun 11, 2014

Feature #686 Disable Default MyCodes
Remove buttons from editor if MyCode is disabled
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 11, 2014

Member

The button will no longer appear on the editor if the MyCode is disabled.

This is now finished.

Member

PaulBender commented Jun 11, 2014

The button will no longer appear on the editor if the MyCode is disabled.

This is now finished.

@PaulBender PaulBender added fixed and removed feedback labels Jun 11, 2014

@xykul

This comment has been minimized.

Show comment
Hide comment
@xykul

xykul Jun 13, 2014

Allow Symbol mycodes
Select No and you receive the error
smilies

xykul commented Jun 13, 2014

Allow Symbol mycodes
Select No and you receive the error
smilies

PaulBender added a commit that referenced this issue Jun 13, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 13, 2014

Member

That should fix it.

Member

PaulBender commented Jun 13, 2014

That should fix it.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 19, 2014

Contributor

@PaulBender please describe the feature - I can't seem to understand what this is and how to test it.

Contributor

PirataNervo commented Jun 19, 2014

@PaulBender please describe the feature - I can't seem to understand what this is and how to test it.

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 19, 2014

Member

It simply disables the default MyCodes (like bold, color, size, etc). When you disable a MyCode, it should stop being parsed everywhere.

Member

PaulBender commented Jun 19, 2014

It simply disables the default MyCodes (like bold, color, size, etc). When you disable a MyCode, it should stop being parsed everywhere.

@JordanMussi

This comment has been minimized.

Show comment
Hide comment
@JordanMussi

JordanMussi Jun 20, 2014

Contributor

I'm not sure if there should be a tab in the Configuration -> MyCode module to point to the setting group...

Contributor

JordanMussi commented Jun 20, 2014

I'm not sure if there should be a tab in the Configuration -> MyCode module to point to the setting group...

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jun 22, 2014

Contributor

Shouldn't 'clickablecode' and 'mycode' setting groups be merged.

Contributor

Sama34 commented Jun 22, 2014

Shouldn't 'clickablecode' and 'mycode' setting groups be merged.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 23, 2014

Contributor

@PaulBender I agree with @Sama34. The Clickable + BB Code group has 4 settings. The MyCode settings should be in there. Besides that, this seems to work fine :)

Contributor

PirataNervo commented Jun 23, 2014

@PaulBender I agree with @Sama34. The Clickable + BB Code group has 4 settings. The MyCode settings should be in there. Besides that, this seems to work fine :)

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 24, 2014

Member

I can merge them.

Member

PaulBender commented Jun 24, 2014

I can merge them.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

That would be good so we can close this.

Contributor

PirataNervo commented Jun 24, 2014

That would be good so we can close this.

PaulBender added a commit that referenced this issue Jun 24, 2014

Feature #686 Disable Default MyCodes
Merged setting groups
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 24, 2014

Member

Done

Member

PaulBender commented Jun 24, 2014

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment