New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buddy System Enhancements #757

Closed
PirataNervo opened this Issue Jun 17, 2014 · 15 comments

Comments

Projects
None yet
4 participants
@PirataNervo
Contributor

PirataNervo commented Jun 17, 2014

List of additions/modifications that have been approved:

  • When a buddy is added, a request is sent instead of being automatically accepted.
  • On the "Edit Lists" page, a list of pending requests (sent; received) is shown.
    • The sent requests can be cancelled
    • The received requests can be accepted or rejected
  • When sending a buddy request, the end user receives a Private Message.
  • Buddy Request PMs can be disabled in the UserCP
  • Option to set approval to automatic
  • Removing a buddy automatically removes the user from the buddy's buddylist as well

@PirataNervo PirataNervo added this to the 1.8 Beta 2 milestone Jun 17, 2014

@PirataNervo PirataNervo self-assigned this Jun 17, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jun 21, 2014

Contributor

Maybe a setting to disable requests may be useful, per user I mean.

Contributor

Sama34 commented Jun 21, 2014

Maybe a setting to disable requests may be useful, per user I mean.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 23, 2014

Contributor

To either choose automatic or manual approval?

Contributor

PirataNervo commented Jun 23, 2014

To either choose automatic or manual approval?

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 23, 2014

Contributor

Added to list.

Contributor

PirataNervo commented Jun 23, 2014

Added to list.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 23, 2014

Contributor

This is now completed. Seems to be working fine, I believe I've covered all cases where it could fail.

Contributor

PirataNervo commented Jun 23, 2014

This is now completed. Seems to be working fine, I believe I've covered all cases where it could fail.

@PirataNervo PirataNervo added the fixed label Jun 23, 2014

PirataNervo added a commit that referenced this issue Jun 24, 2014

Merge pull request #772 from PirataNervo/feature
Adds #757 Buddy System Enhancements
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

I've merged my PR, my tests were all successful and before it gets conflicts, I decided to merge it. If someone finds any issues, I'll fix them immediately.

Contributor

PirataNervo commented Jun 24, 2014

I've merged my PR, my tests were all successful and before it gets conflicts, I decided to merge it. If someone finds any issues, I'll fix them immediately.

@PirataNervo PirataNervo added feedback and removed feedback labels Jun 24, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

@JN-Jones @JordanMussi @Destroy666x @dragonexpert if someone else could test this to make sure it's working as expected, I'd appreciate.

Contributor

PirataNervo commented Jun 24, 2014

@JN-Jones @JordanMussi @Destroy666x @dragonexpert if someone else could test this to make sure it's working as expected, I'd appreciate.

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jun 24, 2014

Contributor
  • After clicking "Add to Buddies" i get the jGrowl success notification. But no users are shown in the "Buddy Requests Sent" box. I need to refresh the page to see the list updated.
  • I will be picky and cry you naming the unique column "id' instead of "rid" :P
  • It seems inconsistent to have a lot of if($mybb->input['action'] == "blabla") but you used elseif($mybb->input['action'] == "blabla").
  • Adding users to the ignore list counts as buddy it seems but not notification is sent and accepting from the UCP works as if it was a buddy request. So the ignore feature is now useless >_>
  • The "I have accepted your buddy request" PM shows a "Invalid PM" error page.

Those are the issues I found.

BTW, what about adding a hook in the send_pm() function? It seems liek it would be rather tedious to hijack the notification being sent (i.e: administrators uses a notification system).

Contributor

Sama34 commented Jun 24, 2014

  • After clicking "Add to Buddies" i get the jGrowl success notification. But no users are shown in the "Buddy Requests Sent" box. I need to refresh the page to see the list updated.
  • I will be picky and cry you naming the unique column "id' instead of "rid" :P
  • It seems inconsistent to have a lot of if($mybb->input['action'] == "blabla") but you used elseif($mybb->input['action'] == "blabla").
  • Adding users to the ignore list counts as buddy it seems but not notification is sent and accepting from the UCP works as if it was a buddy request. So the ignore feature is now useless >_>
  • The "I have accepted your buddy request" PM shows a "Invalid PM" error page.

Those are the issues I found.

BTW, what about adding a hook in the send_pm() function? It seems liek it would be rather tedious to hijack the notification being sent (i.e: administrators uses a notification system).

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

After clicking "Add to Buddies" i get the jGrowl success notification. But no users are shown in the "Buddy Requests Sent" box. I need to refresh the page to see the list updated.

Yeah fixing that now as well.

I will be picky and cry you naming the unique column "id' instead of "rid" :P

Won't change it.

It seems inconsistent to have a lot of if($mybb->input['action'] == "blabla") but you used elseif($mybb->input['action'] == "blabla").
Fixing that now.

Adding users to the ignore list counts as buddy it seems but not notification is sent and accepting from the UCP works as if it was a buddy request. So the ignore feature is now useless >_>

Fixing that now.

The "I have accepted your buddy request" PM shows a "Invalid PM" error page.

I can't reproduce this.

Contributor

PirataNervo commented Jun 24, 2014

After clicking "Add to Buddies" i get the jGrowl success notification. But no users are shown in the "Buddy Requests Sent" box. I need to refresh the page to see the list updated.

Yeah fixing that now as well.

I will be picky and cry you naming the unique column "id' instead of "rid" :P

Won't change it.

It seems inconsistent to have a lot of if($mybb->input['action'] == "blabla") but you used elseif($mybb->input['action'] == "blabla").
Fixing that now.

Adding users to the ignore list counts as buddy it seems but not notification is sent and accepting from the UCP works as if it was a buddy request. So the ignore feature is now useless >_>

Fixing that now.

The "I have accepted your buddy request" PM shows a "Invalid PM" error page.

I can't reproduce this.

PirataNervo added a commit that referenced this issue Jun 24, 2014

Merge pull request #781 from PirataNervo/feature-757
Working on #757 Buddy System Enhancements
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

I've merged my PR, feel free to test it again. I couldn't find any issues. I've tried adding to ignore list with and without people on the Sent List, same thing as people on the Received List. Tried sending requests with and without people on both lists. I've also tried deleting users from the lists and tried the two options I added.

Contributor

PirataNervo commented Jun 24, 2014

I've merged my PR, feel free to test it again. I couldn't find any issues. I've tried adding to ignore list with and without people on the Sent List, same thing as people on the Received List. Tried sending requests with and without people on both lists. I've also tried deleting users from the lists and tried the two options I added.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 27, 2014

Contributor

I'm closing this as I can't find any issues and we haven't had any complaints so far.

Contributor

PirataNervo commented Jun 27, 2014

I'm closing this as I can't find any issues and we haven't had any complaints so far.

@PirataNervo PirataNervo removed the feedback label Jun 27, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 28, 2014

Contributor

Re-opening this. I forgot to cache the templates.

Contributor

PirataNervo commented Jun 28, 2014

Re-opening this. I forgot to cache the templates.

@PirataNervo PirataNervo reopened this Jun 28, 2014

PirataNervo added a commit that referenced this issue Jun 28, 2014

Merge pull request #807 from PirataNervo/feature-757
Caches templates for #757 Buddy System Improvs.
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 28, 2014

Contributor

Alright now it's completely finished.

Contributor

PirataNervo commented Jun 28, 2014

Alright now it's completely finished.

@Stefan-ST

This comment has been minimized.

Show comment
Hide comment
@Stefan-ST

Stefan-ST Jun 29, 2014

Contributor

When sending the PMs the system doesn't respect the language the user receiving the PM has selected. Therefor it is possible that the user receives PMs he doesn't understand.

Contributor

Stefan-ST commented Jun 29, 2014

When sending the PMs the system doesn't respect the language the user receiving the PM has selected. Therefor it is possible that the user receives PMs he doesn't understand.

@Stefan-ST Stefan-ST reopened this Jun 29, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 29, 2014

Contributor

Ah I see what you mean, yes, I have to load the language of the end user.

Contributor

PirataNervo commented Jun 29, 2014

Ah I see what you mean, yes, I have to load the language of the end user.

@PirataNervo PirataNervo added feature and removed enhancement labels Jun 29, 2014

PirataNervo added a commit that referenced this issue Jun 30, 2014

Merge pull request #825 from PirataNervo/feature-757
Fixes bug in #757 Buddy System Enhancements
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 30, 2014

Contributor

Language bug is now fixed.

Contributor

PirataNervo commented Jun 30, 2014

Language bug is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment