Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buddy System Enhancements #757

Closed
8 tasks done
DiogoParrinha opened this issue Jun 17, 2014 · 15 comments
Closed
8 tasks done

Buddy System Enhancements #757

DiogoParrinha opened this issue Jun 17, 2014 · 15 comments

Comments

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 17, 2014

List of additions/modifications that have been approved:

  • When a buddy is added, a request is sent instead of being automatically accepted.
  • On the "Edit Lists" page, a list of pending requests (sent; received) is shown.
    • The sent requests can be cancelled
    • The received requests can be accepted or rejected
  • When sending a buddy request, the end user receives a Private Message.
  • Buddy Request PMs can be disabled in the UserCP
  • Option to set approval to automatic
  • Removing a buddy automatically removes the user from the buddy's buddylist as well
@DiogoParrinha DiogoParrinha added this to the 1.8 Beta 2 milestone Jun 17, 2014
@DiogoParrinha DiogoParrinha self-assigned this Jun 17, 2014
@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jun 21, 2014

Maybe a setting to disable requests may be useful, per user I mean.

Loading

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 23, 2014

To either choose automatic or manual approval?

Loading

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 23, 2014

Added to list.

Loading

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 23, 2014

This is now completed. Seems to be working fine, I believe I've covered all cases where it could fail.

Loading

DiogoParrinha pushed a commit that referenced this issue Jun 24, 2014
Adds #757 Buddy System Enhancements
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

I've merged my PR, my tests were all successful and before it gets conflicts, I decided to merge it. If someone finds any issues, I'll fix them immediately.

Loading

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

@JN-Jones @JordanMussi @Destroy666x @dragonexpert if someone else could test this to make sure it's working as expected, I'd appreciate.

Loading

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jun 24, 2014

  • After clicking "Add to Buddies" i get the jGrowl success notification. But no users are shown in the "Buddy Requests Sent" box. I need to refresh the page to see the list updated.
  • I will be picky and cry you naming the unique column "id' instead of "rid" :P
  • It seems inconsistent to have a lot of if($mybb->input['action'] == "blabla") but you used elseif($mybb->input['action'] == "blabla").
  • Adding users to the ignore list counts as buddy it seems but not notification is sent and accepting from the UCP works as if it was a buddy request. So the ignore feature is now useless >_>
  • The "I have accepted your buddy request" PM shows a "Invalid PM" error page.

Those are the issues I found.

BTW, what about adding a hook in the send_pm() function? It seems liek it would be rather tedious to hijack the notification being sent (i.e: administrators uses a notification system).

Loading

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

After clicking "Add to Buddies" i get the jGrowl success notification. But no users are shown in the "Buddy Requests Sent" box. I need to refresh the page to see the list updated.

Yeah fixing that now as well.

I will be picky and cry you naming the unique column "id' instead of "rid" :P

Won't change it.

It seems inconsistent to have a lot of if($mybb->input['action'] == "blabla") but you used elseif($mybb->input['action'] == "blabla").
Fixing that now.

Adding users to the ignore list counts as buddy it seems but not notification is sent and accepting from the UCP works as if it was a buddy request. So the ignore feature is now useless >_>

Fixing that now.

The "I have accepted your buddy request" PM shows a "Invalid PM" error page.

I can't reproduce this.

Loading

DiogoParrinha pushed a commit that referenced this issue Jun 24, 2014
Working on #757 Buddy System Enhancements
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

I've merged my PR, feel free to test it again. I couldn't find any issues. I've tried adding to ignore list with and without people on the Sent List, same thing as people on the Received List. Tried sending requests with and without people on both lists. I've also tried deleting users from the lists and tried the two options I added.

Loading

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 27, 2014

I'm closing this as I can't find any issues and we haven't had any complaints so far.

Loading

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

Re-opening this. I forgot to cache the templates.

Loading

@DiogoParrinha DiogoParrinha reopened this Jun 28, 2014
DiogoParrinha pushed a commit that referenced this issue Jun 28, 2014
Caches templates for #757 Buddy System Improvs.
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

Alright now it's completely finished.

Loading

@Stefan-MyBB
Copy link
Contributor

@Stefan-MyBB Stefan-MyBB commented Jun 29, 2014

When sending the PMs the system doesn't respect the language the user receiving the PM has selected. Therefor it is possible that the user receives PMs he doesn't understand.

Loading

@Stefan-MyBB Stefan-MyBB reopened this Jun 29, 2014
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 29, 2014

Ah I see what you mean, yes, I have to load the language of the end user.

Loading

DiogoParrinha pushed a commit that referenced this issue Jun 30, 2014
Fixes bug in #757 Buddy System Enhancements
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 30, 2014

Language bug is now fixed.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants