Allow website for certain usergroups only #808

Closed
PirataNervo opened this Issue Jun 28, 2014 · 14 comments

Comments

Projects
None yet
4 participants
@PirataNervo
Contributor

PirataNervo commented Jun 28, 2014

Restrict the website field to certain groups only, i.e. by default it is enabled but admins should be able to turn it off for certain groups.

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jul 12, 2014

Contributor

I can do this on #900, I could add a groupselect setting for each field.

Contributor

Sama34 commented Jul 12, 2014

I can do this on #900, I could add a groupselect setting for each field.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 14, 2014

Contributor

@Sama34 not necessary, I'll do this :)

Contributor

PirataNervo commented Jul 14, 2014

@Sama34 not necessary, I'll do this :)

PirataNervo added a commit that referenced this issue Jul 14, 2014

Merge pull request #923 from PirataNervo/feature-808
Finishes #808 Allow website for certain usergroups only
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 14, 2014

Contributor

Merged my PR, everything seemed to work fine for me.

Contributor

PirataNervo commented Jul 14, 2014

Merged my PR, everything seemed to work fine for me.

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jul 14, 2014

Contributor

If a user adds/changes website before his group is disallowed to do that, it's still displayed in posts/profile. usergroup['canchangewebsite'] checks should be added there like for signature (in posts at least).

BTW, signature usergroup permissions are checked in posts only, a check should be added to member profile too.

Contributor

Destroy666x commented Jul 14, 2014

If a user adds/changes website before his group is disallowed to do that, it's still displayed in posts/profile. usergroup['canchangewebsite'] checks should be added there like for signature (in posts at least).

BTW, signature usergroup permissions are checked in posts only, a check should be added to member profile too.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 14, 2014

Contributor

Yeah you're right, I need to add that check for profile and postbit.

As for the signature permissions, they're not related to this issue.

Contributor

PirataNervo commented Jul 14, 2014

Yeah you're right, I need to add that check for profile and postbit.

As for the signature permissions, they're not related to this issue.

PirataNervo added a commit that referenced this issue Jul 16, 2014

Merge pull request #937 from PirataNervo/feature-808
Fixes #808 Allow website for certain usergroups only
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 16, 2014

Contributor

This is now finished. Closing.

Contributor

PirataNervo commented Jul 16, 2014

This is now finished. Closing.

@PirataNervo PirataNervo removed the feedback label Jul 16, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jul 17, 2014

Member

You forgot to add the canchangewebsite column to the pgsql_db_tables.php and sqlite_db_tables.php files ;)

Member

PaulBender commented Jul 17, 2014

You forgot to add the canchangewebsite column to the pgsql_db_tables.php and sqlite_db_tables.php files ;)

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 17, 2014

Contributor

I always forget those...thanks.

Contributor

PirataNervo commented Jul 17, 2014

I always forget those...thanks.

@PirataNervo PirataNervo reopened this Jul 17, 2014

PirataNervo added a commit that referenced this issue Jul 17, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 17, 2014

Contributor

Alright fixed. Closing again.

Contributor

PirataNervo commented Jul 17, 2014

Alright fixed. Closing again.

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jul 17, 2014

Contributor

@PirataNervo, you forgot to fix these issues reported by Omar though: #937

Contributor

Destroy666x commented Jul 17, 2014

@PirataNervo, you forgot to fix these issues reported by Omar though: #937

@Destroy666x Destroy666x reopened this Jul 17, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jul 18, 2014

Contributor

I'm sure I posted this somewhere, but the website is still searchable through the member list search feature.

Contributor

Sama34 commented Jul 18, 2014

I'm sure I posted this somewhere, but the website is still searchable through the member list search feature.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 18, 2014

Contributor

@Destroy666x thanks.
@Sama34 the users aren't able to see the website of the user though. They can search it but can't see it. They can guess it of course and eventually find it. But it's not feasible to re-write the search query to block results from users that are not allowed to change their website.

Contributor

PirataNervo commented Jul 18, 2014

@Destroy666x thanks.
@Sama34 the users aren't able to see the website of the user though. They can search it but can't see it. They can guess it of course and eventually find it. But it's not feasible to re-write the search query to block results from users that are not allowed to change their website.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 18, 2014

Contributor

New PR

Contributor

PirataNervo commented Jul 18, 2014

New PR

Destroy666x added a commit that referenced this issue Jul 18, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 18, 2014

Contributor

Closing.

Contributor

PirataNervo commented Jul 18, 2014

Closing.

@PirataNervo PirataNervo removed their assignment Jan 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment