Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow website for certain usergroups only #808

Closed
DiogoParrinha opened this issue Jun 28, 2014 · 14 comments
Closed

Allow website for certain usergroups only #808

DiogoParrinha opened this issue Jun 28, 2014 · 14 comments

Comments

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

Restrict the website field to certain groups only, i.e. by default it is enabled but admins should be able to turn it off for certain groups.

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jul 12, 2014

I can do this on #900, I could add a groupselect setting for each field.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jul 14, 2014

@Sama34 not necessary, I'll do this :)

DiogoParrinha pushed a commit that referenced this issue Jul 14, 2014
Finishes #808 Allow website for certain usergroups only
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jul 14, 2014

Merged my PR, everything seemed to work fine for me.

@Destroy666x
Copy link
Contributor

@Destroy666x Destroy666x commented Jul 14, 2014

If a user adds/changes website before his group is disallowed to do that, it's still displayed in posts/profile. usergroup['canchangewebsite'] checks should be added there like for signature (in posts at least).

BTW, signature usergroup permissions are checked in posts only, a check should be added to member profile too.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jul 14, 2014

Yeah you're right, I need to add that check for profile and postbit.

As for the signature permissions, they're not related to this issue.

DiogoParrinha pushed a commit that referenced this issue Jul 16, 2014
Fixes #808 Allow website for certain usergroups only
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jul 16, 2014

This is now finished. Closing.

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 17, 2014

You forgot to add the canchangewebsite column to the pgsql_db_tables.php and sqlite_db_tables.php files ;)

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jul 17, 2014

I always forget those...thanks.

@DiogoParrinha DiogoParrinha reopened this Jul 17, 2014
DiogoParrinha pushed a commit that referenced this issue Jul 17, 2014
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jul 17, 2014

Alright fixed. Closing again.

@Destroy666x
Copy link
Contributor

@Destroy666x Destroy666x commented Jul 17, 2014

@PirataNervo, you forgot to fix these issues reported by Omar though: #937

@Destroy666x Destroy666x reopened this Jul 17, 2014
@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jul 18, 2014

I'm sure I posted this somewhere, but the website is still searchable through the member list search feature.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jul 18, 2014

@Destroy666x thanks.
@Sama34 the users aren't able to see the website of the user though. They can search it but can't see it. They can guess it of course and eventually find it. But it's not feasible to re-write the search query to block results from users that are not allowed to change their website.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jul 18, 2014

New PR

Destroy666x added a commit that referenced this issue Jul 18, 2014
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jul 18, 2014

Closing.

@DiogoParrinha DiogoParrinha removed their assignment Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.