send_pm () should consider users language.

[Sama34]

The send_pm () function should consider the language of the user to whom the PM is being sent.

@mybb/developers

• managegroup.php
• usercp.php
• inc/class_custommoderation.php
• inc/datahandlers/post.php

Reference: #757 (comment)

[DiogoParrinha]

Definitely. #757 would have its temporary fix removed then.

[Sama34]

Please review 191f5ee . Seems like the best approach but seems dirty.

@mybb/developers

[JordanMussi]

That seems fine at first glance.

[DiogoParrinha]

Right now this shouldn't work at all. You added a new option called 'language' but it's never used. There should be no parameter language, it should simply load the language of the end user. Then switch back to the original.

[DiogoParrinha]

@Sama34 (feel free to correct me)

[Sama34]

language is the language of the user to whom the PM is being sent. It is passed within the $pm array in the send_pm() function. So I think it does what you suggest it should be doing.

It did work for me.

EDIT: It only works for managegroup.php, usercp.php wasn't fully edited..

[DiogoParrinha]

Yes that's what I meant. The language property was never implemented in some places where send_pm was used.

[Sama34]

This should now be finished.

@PirataNervo, for inc/datahandlers/post.php there is a wicked code there that loads a new language handler when sending an e-mail notification (I updated the code when it is a PM one to use this issue's method).

I think that should be updated as well, adding a function to build the e-mail and store it in the DB. That should be marked as a bug since it is there since 1.6. What do you think?

@mybb/developers

[Sama34]

inc/class_custommoderation.php doesn't use language strings so unless we add that feature on the future it doesn't needs updating.

[DiogoParrinha]

Sounds good to me, this just needs testing then.

[Sama34]

Ok for the sake of get beta 3 done with, I'm going to close this.

It worked for me so please consider opening a new issue/thread if you find bugs.