AJAX for Security Questions #894

Closed
PaulBender opened this Issue Jul 7, 2014 · 14 comments

Comments

Projects
None yet
6 participants
@PaulBender
Member

PaulBender commented Jul 7, 2014

An AJAX check should be added for Security Questions on registration that tells the user if their answer is right or wrong and allow the user to AJAX refresh and get a new question.

@PaulBender PaulBender added this to the 1.8 Beta 3 milestone Jul 7, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jul 17, 2014

Contributor

@PirataNervo you seem to be the most experienced with JavaSscript, could you add this?

Contributor

Sama34 commented Jul 17, 2014

@PirataNervo you seem to be the most experienced with JavaSscript, could you add this?

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 17, 2014

Member

If not, I will try and find the time after I finish my other tasks.

On 17 Jul 2014, at 07:41, Omar Gonzalez notifications@github.com wrote:

@PirataNervo you seem to be the most experienced with JavaSscript, could you add this?


Reply to this email directly or view it on GitHub.

Member

euantorano commented Jul 17, 2014

If not, I will try and find the time after I finish my other tasks.

On 17 Jul 2014, at 07:41, Omar Gonzalez notifications@github.com wrote:

@PirataNervo you seem to be the most experienced with JavaSscript, could you add this?


Reply to this email directly or view it on GitHub.

@ATofighi

This comment has been minimized.

Show comment
Hide comment
@ATofighi

ATofighi Jul 17, 2014

Contributor

I think MyBB developers should fix other registration bugs before this:
http://community.mybb.com/thread-155738.html

Contributor

ATofighi commented Jul 17, 2014

I think MyBB developers should fix other registration bugs before this:
http://community.mybb.com/thread-155738.html

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 17, 2014

Member

Beta 3 is the last milestone for features though. If we miss beta 3 for this, it won't get into 1.8.

Member

euantorano commented Jul 17, 2014

Beta 3 is the last milestone for features though. If we miss beta 3 for this, it won't get into 1.8.

@ATofighi

This comment has been minimized.

Show comment
Hide comment
@ATofighi

ATofighi Jul 17, 2014

Contributor

But those bugs make javascript error and next js codes don't work.

Contributor

ATofighi commented Jul 17, 2014

But those bugs make javascript error and next js codes don't work.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 17, 2014

Contributor

@ATofighi all bugs will be fixed, don't worry.
@Sama34 I'll see what I can do. @euantorano this isn't technically a feature/enhancement - this is more like "finishing the security questions feature". And that can be done regardless of being in Beta 3 or not. This is not something big, just something that should have been done already. Still, I'll see what I can do about putting it into Beta 3.

Contributor

PirataNervo commented Jul 17, 2014

@ATofighi all bugs will be fixed, don't worry.
@Sama34 I'll see what I can do. @euantorano this isn't technically a feature/enhancement - this is more like "finishing the security questions feature". And that can be done regardless of being in Beta 3 or not. This is not something big, just something that should have been done already. Still, I'll see what I can do about putting it into Beta 3.

@PirataNervo PirataNervo self-assigned this Jul 17, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 17, 2014

Contributor

I'm going to work on this tomorrow.

Contributor

PirataNervo commented Jul 17, 2014

I'm going to work on this tomorrow.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 18, 2014

Contributor

Alright this seems pretty straightforward. I'll just need to add a new validator rule for the question field and then add the question <-> answer validation to xmlhttp.php.

Contributor

PirataNervo commented Jul 18, 2014

Alright this seems pretty straightforward. I'll just need to add a new validator rule for the question field and then add the question <-> answer validation to xmlhttp.php.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 19, 2014

Contributor

@PaulBender I'm going to replace the line:

$valid_answers = explode("\n", $question['answer']);

By

$valid_answers = preg_split("/\r\n|\n|\r/", $question['answer']);

EDIT: It seems we're using explode everywhere, though I don't agree with it. So I won't do the change above.

Contributor

PirataNervo commented Jul 19, 2014

@PaulBender I'm going to replace the line:

$valid_answers = explode("\n", $question['answer']);

By

$valid_answers = preg_split("/\r\n|\n|\r/", $question['answer']);

EDIT: It seems we're using explode everywhere, though I don't agree with it. So I won't do the change above.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 19, 2014

Contributor

PR created, working fine for me.

Contributor

PirataNervo commented Jul 19, 2014

PR created, working fine for me.

@PirataNervo PirataNervo added the fixed label Jul 19, 2014

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jul 19, 2014

Contributor

Seems to work, you missed the 2nd part though:

and get a new question.

It's crucial for some forums which use several hard niche-specific questions.

Contributor

Destroy666x commented Jul 19, 2014

Seems to work, you missed the 2nd part though:

and get a new question.

It's crucial for some forums which use several hard niche-specific questions.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 19, 2014

Contributor

Working on that now.

Contributor

PirataNervo commented Jul 19, 2014

Working on that now.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
Contributor

PirataNervo commented Jul 19, 2014

@Destroy666x done!

PirataNervo added a commit that referenced this issue Jul 19, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 19, 2014

Contributor

Merged my PR, closed.

Contributor

PirataNervo commented Jul 19, 2014

Merged my PR, closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment