Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJAX for Security Questions #894

Closed
Starpaul20 opened this issue Jul 7, 2014 · 14 comments
Closed

AJAX for Security Questions #894

Starpaul20 opened this issue Jul 7, 2014 · 14 comments
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@Starpaul20
Copy link
Member

An AJAX check should be added for Security Questions on registration that tells the user if their answer is right or wrong and allow the user to AJAX refresh and get a new question.

@Starpaul20 Starpaul20 added this to the 1.8 Beta 3 milestone Jul 7, 2014
@Sama34
Copy link
Contributor

Sama34 commented Jul 17, 2014

@PirataNervo you seem to be the most experienced with JavaSscript, could you add this?

@euantorano
Copy link
Member

If not, I will try and find the time after I finish my other tasks.

On 17 Jul 2014, at 07:41, Omar Gonzalez notifications@github.com wrote:

@PirataNervo you seem to be the most experienced with JavaSscript, could you add this?


Reply to this email directly or view it on GitHub.

@ATofighi
Copy link
Contributor

I think MyBB developers should fix other registration bugs before this:
http://community.mybb.com/thread-155738.html

@euantorano
Copy link
Member

Beta 3 is the last milestone for features though. If we miss beta 3 for this, it won't get into 1.8.

@ATofighi
Copy link
Contributor

But those bugs make javascript error and next js codes don't work.

@DiogoParrinha
Copy link
Contributor

@ATofighi all bugs will be fixed, don't worry.
@Sama34 I'll see what I can do. @euantorano this isn't technically a feature/enhancement - this is more like "finishing the security questions feature". And that can be done regardless of being in Beta 3 or not. This is not something big, just something that should have been done already. Still, I'll see what I can do about putting it into Beta 3.

@DiogoParrinha DiogoParrinha self-assigned this Jul 17, 2014
@DiogoParrinha
Copy link
Contributor

I'm going to work on this tomorrow.

@DiogoParrinha
Copy link
Contributor

Alright this seems pretty straightforward. I'll just need to add a new validator rule for the question field and then add the question <-> answer validation to xmlhttp.php.

@DiogoParrinha
Copy link
Contributor

@PaulBender I'm going to replace the line:

$valid_answers = explode("\n", $question['answer']);

By

$valid_answers = preg_split("/\r\n|\n|\r/", $question['answer']);

EDIT: It seems we're using explode everywhere, though I don't agree with it. So I won't do the change above.

@DiogoParrinha
Copy link
Contributor

PR created, working fine for me.

@Destroy666x
Copy link
Contributor

Seems to work, you missed the 2nd part though:

and get a new question.

It's crucial for some forums which use several hard niche-specific questions.

@DiogoParrinha
Copy link
Contributor

Working on that now.

@DiogoParrinha
Copy link
Contributor

@Destroy666x done!

DiogoParrinha pushed a commit that referenced this issue Jul 19, 2014
Adds AJAX to Security questions #894
@DiogoParrinha
Copy link
Contributor

Merged my PR, closed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

6 participants