-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AJAX for Security Questions #894
Comments
@PirataNervo you seem to be the most experienced with JavaSscript, could you add this? |
If not, I will try and find the time after I finish my other tasks.
|
I think MyBB developers should fix other registration bugs before this: |
Beta 3 is the last milestone for features though. If we miss beta 3 for this, it won't get into 1.8. |
But those bugs make javascript error and next js codes don't work. |
@ATofighi all bugs will be fixed, don't worry. |
I'm going to work on this tomorrow. |
Alright this seems pretty straightforward. I'll just need to add a new validator rule for the question field and then add the question <-> answer validation to xmlhttp.php. |
@PaulBender I'm going to replace the line: $valid_answers = explode("\n", $question['answer']); By $valid_answers = preg_split("/\r\n|\n|\r/", $question['answer']); EDIT: It seems we're using explode everywhere, though I don't agree with it. So I won't do the change above. |
PR created, working fine for me. |
Seems to work, you missed the 2nd part though:
It's crucial for some forums which use several hard niche-specific questions. |
Working on that now. |
@Destroy666x done! |
Adds AJAX to Security questions #894
Merged my PR, closed. |
An AJAX check should be added for Security Questions on registration that tells the user if their answer is right or wrong and allow the user to AJAX refresh and get a new question.
The text was updated successfully, but these errors were encountered: