Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memberlist sorting through headings #914

Closed
JordanMussi opened this issue Jul 13, 2014 · 9 comments
Closed

Memberlist sorting through headings #914

JordanMussi opened this issue Jul 13, 2014 · 9 comments
Assignees
Milestone

Comments

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jul 13, 2014

it'd be nice if we could sort the member list page by clicking on the text like 'username', 'joined', 'post count', etc.:
Image

Should be easy enough to implement. I'll see if there are also other places where this should be added, I don't think there would be though...

@JordanMussi JordanMussi added this to the 1.8 Beta 3 milestone Jul 13, 2014
@JordanMussi JordanMussi self-assigned this Jul 13, 2014
@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jul 13, 2014

IIRC the code is already there, we just need to convert the words to links. Isn't it?

@Destroy666x Destroy666x added enhancement and removed feature labels Jul 14, 2014
@JordanMussi
Copy link
Member Author

@JordanMussi JordanMussi commented Jul 15, 2014

Yeah, it should be a simple template edit....

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jul 16, 2014

@JordanMussi get to work then! :P

@JordanMussi
Copy link
Member Author

@JordanMussi JordanMussi commented Jul 17, 2014

On the case...

JordanMussi added a commit to JordanMussi/MyBB that referenced this issue Jul 17, 2014
@JordanMussi JordanMussi added the fixed label Jul 17, 2014
@JordanMussi JordanMussi changed the title Member list sorting Memberlist sorting Jul 17, 2014
@JordanMussi JordanMussi changed the title Memberlist sorting Memberlist sorting through headings Jul 17, 2014
@JordanMussi
Copy link
Member Author

@JordanMussi JordanMussi commented Jul 17, 2014

Fixed in #941.

Haha this is #914 and the Pull Request is #941. Little things like that make my day! 👅

JordanMussi added a commit to JordanMussi/MyBB that referenced this issue Jul 17, 2014
@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jul 18, 2014

Seems to work for me. But shouldn't some be ASC by default? I.e: post count, thread count, etc.

@JordanMussi
Copy link
Member Author

@JordanMussi JordanMussi commented Jul 18, 2014

All are asc by default.... Did you mean desc?

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jul 19, 2014

Yeah :p

@JordanMussi JordanMussi added feedback and removed fixed labels Jul 19, 2014
@Sama34 Sama34 added the fixed label Jul 20, 2014
@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jul 20, 2014

@JordanMussi I pushed your changes directly and applied mine after that.

It works for me.

@Sama34 Sama34 closed this Jul 20, 2014
@JordanMussi JordanMussi removed the feedback label Jul 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.