Remove PHP closing tags

[DiogoParrinha]

18fcbe8#commitcomment-7073774
Quote:

Wouldn't hurt to take the ?> out of most MyBB files entirely...
http://php.net/manual/en/language.basic-syntax.phptags.php
If a file is pure PHP code, it is preferable to omit the PHP closing tag at the end of the file.

[Sama34]

I think we can do this together with the typecast one, so we can push it in beta 3.

[DiogoParrinha]

I can write a script to do this too yes.

[Sama34]

If a file is pure PHP code [...]

Does it means it wouldn't work if in-line HTML is used? There are some files that do, that should be easy to fix.

[euantorano]

Yes, it does mean that Omar.

I'm completely for this. It is a well known best practise, but I'm sure there used to be a style guideline against it.

On 20 Jul 2014, at 21:54, Omar Gonzalez notifications@github.com wrote:

If a file is pure PHP code

Does it means it wouldn't work if in-line HTML is used? There are some files that do, we can fix that too.

—
Reply to this email directly or view it on GitHub.

[Sama34]

http://docs.mybb.com/Development_Standards.html#PHP_Code_Demarcation

It was decided last year we wouldn't be removing them. But half that page is ignored anyways and there is nothing actually wrong with this, is it?

[DiogoParrinha]

Yes, some files that contain inline HTML (especially in the ACP). The script I'll create will need to check that.

[Sama34]

I can update those so the script simply removes the endings. I even think this can be done manually :P

It is not like the typecast one that checks for multiple instances.

[DiogoParrinha]

This is done.

[avril-gh]

php closing tags still re-created in various places.
#1276