Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3640 jQuery 3.3.1 + Compatibility Update #3639

Merged
merged 9 commits into from May 6, 2019

Conversation

Projects
None yet
7 participants
@effone
Copy link
Member

commented Apr 3, 2019

Attempt to fix #3640
This also closes #2542, closes #2754, closes #3588 and closes #3591

  • Upgrade jQuery 3.3.1.
    Running Migrate console logger 3.0.1
    Various compatibility code updates throughout templates / js files

  • Upgrade jEditable. Doesn't worth.
  • Upgrade jQuery Validation.

  • Upgrade SCEditor to 2.1.3:
  • Upgrade bbcodes_sceditor.js compatible with jQuery 3.3.1
  • Switch bbcode from plugin to format
  • Old missing themes & editor styles to fix / restore + custom command icons
  • Dropdown creator to point first node as per new syntax
  • PHP / CODE mixup issue

Known ignored deprecations:

  • Usage of pseudo expr[':'] in latest jquery.ui library
  • Usage of unique in place of uniqueSort in latest jquery.ui library
  • Various deprecated methods in jEditable
  • Not in MyBB core but if some plugins script use setInterval() it will throw warning from jQuery core. Don't panic, ignore it.
    jquery/jquery-migrate#298

  • Final check + Version Bumps

@effone effone added this to the 1.8.21 milestone Apr 3, 2019

@effone effone requested a review from WildcardSearch Apr 3, 2019

@WildcardSearch

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@effone I will try to take a look tonight, if I get time.

@effone

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

Its still under progress. I'll ping you when its finished.

@effone effone changed the title jQuery 3.3.1 + Compatibility Update Fixes #3640 jQuery 3.3.1 + Compatibility Update Apr 3, 2019

@effone effone removed this from the 1.8.21 milestone Apr 3, 2019

@Eldenroot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@MinusPL - as I saw your discussion and a thread with all known bugs in sceditor after last update, would be nice if you could test his PR and make a report :) thank you!

I will test myself, but I have not been using SCeditor for almost 3 years.

@effone

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

Important Note for Latest SCEditor Usage

  • While upgrading it is highly recommended to delete entire existing jscripts/sceditor directory and copy fresh from the new package. Some files are not required to exist and things may break if they do.

  • All the existing themes are required to codebuttons template reverted to default. This will not break any theme's style but there are critical parameter changes to take the SCE affect the textarea.

  • As of SCE 2.1.3 the two existing themes monocons and buttons are dropped with a good logic that icon systems are not theme, they are part of theme. Instead an icon system has been implemented. The included icon packs for now are monocons and material, so that you can use those icon systems with any theme. After successful upgrade; consider re-applying the Editor Style from ACP, theme settings if you get broken toolbar in editor.

  • Considering the fact that the ACP is gonna be rewritten and uncertain future of SCE with MyBB; we are not including any option to choose for icon system. So attention vector icon lovers: You have to implement the icon system manually in codebuttons if you choose to use. The implementation is pretty simple and a snapshot can describe it all.
    snap

Any further assistance - feel free to use Community Forums Support Section.

@effone effone removed the s:in-progress label Apr 8, 2019

@MinusPL

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Tested all combination that came to my mind.
Editor seems to work properly.
Every issue that I wrote in my thread is resolved. So this change makes it work as it should.
Thanks for your work. 👍

@effone

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

... and thank you sooo much for testing. Thats an even boring job. Thank you for taking all that pain and providing feedback.

@euantorano

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Excellent work @effone! Thanks so much for taking the time and effort.

@zAnonimo

This comment has been minimized.

Copy link

commented Apr 26, 2019

Hi, first of all, thanks a lot @effone for trying to fix this issue. As I told you in the MyBB's Discord, I'm testing this live in a large forum. Some errors started to appear to large threads, when the thread is really long, it seems to damage the style of the {posts} placeholder. Inspecting a lil bit the google chrome inspector, seems like most of the content gets out of <div id="post_content">.

Happens in default theme (I don't support the default theme so don't be afraid about missing images)
image

And my custom theme (modified Emerald)
image

Another think that I found out, is that SCEditor doesn't take the width of the screen properly. I have 1600x900 monitor and it allows me to expand the textbox to a maximum of 625width. I checked a lil bit .js file but didn't get any result (I'm not really used to javascript/jquery). This happens in both themes too.
image

This is all what I found so far. The SCEditor applies everything as it's supposed to do. Let me know if you can reproduce this errors and if not, I'll try to check further if it's a error in my side. Greetings!

@effone

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

Do you have this setting in place (in codebuttons template):
width: "100%",
That should fix the width issue.

For the post breakage need to check the parsed code where it has happened and have to identify the defective element. Apparently it looks like a parser issue, not SCE.

@zAnonimo

This comment has been minimized.

Copy link

commented Apr 27, 2019

Do you have this setting in place (in codebuttons template):
width: "100%",
That should fix the width issue.

For the post breakage need to check the parsed code where it has happened and have to identify the defective element. Apparently it looks like a parser issue, not SCE.

I added width: "100%", to my opt_editor (codeblock template). It didn't fix the width issue in my side. I really appreciate if you try to reproduce the parsing problem. Anyways, thanks a lot for your efforts! I'll be waiting for any fix 👍

@effone

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

Alright, I have inspected the 2 mentioned issues on site.
The width issue is not there with the setting in place. Its at your end and probably a CF cache issue.
The postbit breaking is entirely improper flex layout of your postbit, parser and SCE parse processes are fine.

@dvz dvz merged commit 24a71c9 into mybb:feature May 6, 2019

@effone effone deleted the effone:jquery-update branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.