Implement PDO based DB drivers for MySQL and PostgreSQL #4193
Conversation
| { | ||
| // first, check for an IPv6 address - IPv6 addresses always start with `[` | ||
| $openingSquareBracket = strpos($hostname, '['); | ||
| if ($openingSquareBracket === 0) { |
There was a problem hiding this comment.
Note: This logic is not yet tested. I believe that other drivers doing much the same thing would never have worked with IPv6 addressed DB hosts...
| return false; | ||
| } | ||
|
|
||
| if (preg_match('/^\\s*SELECT\\b/i', $query->queryString) === 1) { |
There was a problem hiding this comment.
Note: using num_rows with PDO is not optimal at all. We need to review usages within the core and see when/why we use num-rows and if they can be replaced so that we don't hit this path too often.
This works better with the old mysql_ type functions as those functions buffer results internally, which PDO does not do.
| return $fieldstring; | ||
| } | ||
|
|
||
| public function __set($name, $value) |
There was a problem hiding this comment.
Note: This special handling is important to ensure compatibility.
|
I haven't yet tested the MySQL PDO driver, but have tested the Postgres one. I'd like to land this in 1.8.25 but not make too much noise about it. Then during the cycle for 1.8.26 I plan to add some more methods to all of the DB drivers to support prepared statements (which will be emulated for some drivers). |
Enahnce the dbpdoEngine class in a few ways: - Disable emulated prepares. - Rather than dying when failing to connect, throw an exception. - Make some properties private where possible. - Add comments to properties. - Add `query_prepared` method. - Use object hash to identify queries, rather than assigning an ID property. - Default name of query for `insert_id` to `NULL` rather than an empty string. This matches the underlying function. - Set visibility for functions.
Implement `insert_query`, `insert_query_multiple`, `update_query`. Use heredoc to format HTML for query explanations, which makes the HTML more readable.
Moved some methods to the postgres specific PDO class as they have different requirements (such as rewriting LIMITs).
Escaping is handled slightly differently to the standard pgsql driver
euantorano
force-pushed
the
develop/pdo-pgsql
branch
from
9abcf10 to
6ae1e4e
Compare
|
I've now done some testing of this with MySQL too and ran through an install and a few key pages. I'd very much appreciate it if others could test this PR. Upgraded boards can opt-in to the PDO based drivers by modifying $config['database']['type'] = 'mysql_pdo';$config['database']['type'] = 'pgsql_pdo';Once altered, there shouldn't be any visible change if all goes well. |
I haven't done any systematic testing, but have been using the |
|
Awesome, thanks Laird!
…On Sat, 13 Feb 2021, at 11:36, Laird wrote:
> I'd very much appreciate it if others could test this PR.
I haven't done any systematic testing, but have been using the
`mysql_pdo` driver for about two weeks on my local dev board whilst
working on a plugin, and have had no problems so far. Seems good.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4193 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW24L2WITDRPAKKIJVXS3S6ZP2TANCNFSM4UZXSIOA>.
|
Previous incarnation missed the closing `]` for IPv6 addresses, and had some questionable logic.
|
Seems some changes were missing for this. I think I’d simply dropped the else but must not have staged it. Will fix later.
…On Thu, 25 Mar 2021, at 20:28, dvz wrote:
***@***.**** commented on this pull request.
In inc/db_pgsql.php
<#4193 (comment)>:
> @@ -451,6 +451,8 @@ function fetch_field($query, $field, $row=false)
{
return pg_fetch_result($query, $row, $field);
}
+
+ return pg_fetch_result($query, $row, $field);
Unreachable statement
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4193 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW24JGJ6VIHNWDHYZB2ULTFOMIPANCNFSM4UZXSIOA>.
|
|
I'm going ahead and merging this, it's had a fair bit of testing now I believe. |
[Rebased for 1.9 by Laird] * dbpdoEngine enhancements Enahnce the dbpdoEngine class in a few ways: - Disable emulated prepares. - Rather than dying when failing to connect, throw an exception. - Make some properties private where possible. - Add comments to properties. - Add `query_prepared` method. - Use object hash to identify queries, rather than assigning an ID property. - Default name of query for `insert_id` to `NULL` rather than an empty string. This matches the underlying function. - Set visibility for functions. * Working on PDO versions of MySQL and PostgreSQL DB * Implement further postgres PDO methods. * Fix spelling, implement some more methods * Improve SELECT query detection. Implement `insert_query`, `insert_query_multiple`, `update_query`. Use heredoc to format HTML for query explanations, which makes the HTML more readable. * Implement `show_fields_from`. * Implement more DB methods for postgres PDO driver * Move database methods for Postgres PDO connector * Start working in integrating Postgres PDO driver Moved some methods to the postgres specific PDO class as they have different requirements (such as rewriting LIMITs). * Handle escaping binary and decoding binary Escaping is handled slightly differently to the standard pgsql driver * Implement missing methods. Handl DB type property. * Starting work on mySQL PDO driver. * Implement more mYSQL PDO methods * Fix mybb#4192 - set default when modifying columns * Drop the query_prepared function for now. * Handle exception opening SQLite DB. * Implement all MySQL functions. * Handle mysql_pdo DB type. * Prefer string inteprolation over concatenation. * Check for MySQL in supported PDO drivers. * Make explain property public and fix formatting of explain. Fix list_tables method. * Close cursor for query in free_result. * Update function to parse hostname Previous incarnation missed the closing `]` for IPv6 addresses, and had some questionable logic. * Fix unreachable statement
4 participants
This PR adds two new database drivers for MySQL and PostgreSQL that make use of PDO.
It also amends the SQLite driver to not just die if the database file cannot be opened.
It also fixes #4192.