Fixes #4262 - Exclude bots, spiders and thread authors from thread views

[Eldenroot]

Resolves #4262

Thank you buddy @lairdshaw - for your mentoring, I really appreciate it!

[lairdshaw]

Happy to have helped, buddy. I think you ended up with a good outcome.

[dvz]

It may be more intuitive to flip the meaning of these settings and use include instead of exclude.

[lairdshaw]

It may be more intuitive to flip the meaning of these settings and use include instead of exclude.

Doh. It was me who advised the inversion. I still stand by that choice. I think inclusion is more ambiguous in this scenario. e.g., The user is a guest, and the setting says "include guests" so s/he is included, but the user is also not a spider, and the setting says "include spiders", so on that basis should s/he not be included...?... It's ambiguous. A principle of exclusion is not (IMO) as ambiguous: if any of the exclusion criteria are applicable, then the user is excluded. If none of them apply, then the user is included.

(I do realise that from a strictly logical point of view, this whole argument could be turned around on me, so I guess all I'm saying is that I find exclusion more intuitive - but if the consensus is that it's not, then that's OK with me).

[Eldenroot]

@dvz thank you, now it should be fine.

[dvz]

Currently No values would result in double negatives - skimming through descriptions and spotting [...] guests [...] with a Yes / No setting may be interpreted as include/exclude guests.

Would include X be mistaken for [only] include X, rather than [also] include X?

We can also use alternatives like Increment Thread View Count on Guest Visits.

[Sama34]

I think a include approach with a Increment Thread View Count on Guest Visits wording is the best approach to avoid confusion.

[Eldenroot]

@Sama34 - please check this comment from @dvz - #4262 (comment)

It was changed to off by default because of the request.

[lairdshaw]

I defer to your stronger position, @dvz and @Sama34. Exclusion was not, as I'd initially thought, as good a framing as inclusion. You guys are correct...

[Eldenroot]

Thank you all for your valuable feedback! Now it should be fixed and all your suggestions were implemented.