Fix #30 - fixed @BMintern's indentions #50

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@lukaszklis

Fixed the whitespace issue in #29.

@r3pek

This comment has been minimized.

Show comment
Hide comment
@r3pek

r3pek May 7, 2013

@lukaszklis your patch isn't 100% correct

In your case, you issue STARTTLS right after the connection being made but you need to send EHLO first or some servers at least (I don't know what you tested it), will just drop the connection.

r3pek commented May 7, 2013

@lukaszklis your patch isn't 100% correct

In your case, you issue STARTTLS right after the connection being made but you need to send EHLO first or some servers at least (I don't know what you tested it), will just drop the connection.

@Stefan-ST

This comment has been minimized.

Show comment
Hide comment
@Stefan-ST

Stefan-ST Jul 3, 2013

Contributor

Correct, this fix may not work with all mail server.
See: http://dev.mybb.com/issues/1846

Contributor

Stefan-ST commented Jul 3, 2013

Correct, this fix may not work with all mail server.
See: http://dev.mybb.com/issues/1846

@Stefan-ST Stefan-ST closed this Jul 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment