Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #30 - fixed @BMintern's indentions #50

Closed
wants to merge 1 commit into from

Conversation

@lukaszklis
Copy link

@lukaszklis lukaszklis commented Feb 25, 2013

Fixed the whitespace issue in #29.

@r3pek
Copy link

@r3pek r3pek commented May 7, 2013

@lukaszklis your patch isn't 100% correct

In your case, you issue STARTTLS right after the connection being made but you need to send EHLO first or some servers at least (I don't know what you tested it), will just drop the connection.

@Stefan-ST
Copy link
Contributor

@Stefan-ST Stefan-ST commented Jul 3, 2013

Correct, this fix may not work with all mail server.
See: http://dev.mybb.com/issues/1846

@Stefan-ST Stefan-ST closed this Jul 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.