Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to sort Private Messages in inbox and other folders #70

Merged
merged 3 commits into from Jun 9, 2013
Merged

Ability to sort Private Messages in inbox and other folders #70

merged 3 commits into from Jun 9, 2013

Conversation

Starpaul20
Copy link
Member

@Starpaul20 Starpaul20 commented May 5, 2013

From my list of suggestions I posted here; this adds the ability to sort your private message folders by either subject, username or date sent.

@nmalcolm
Copy link
Contributor

nmalcolm commented Jun 9, 2013

These are some issues here. Ordering "Sent To" in Sent Items or Drafts produces an SQL error.

SQL Error: 1054 - Unknown column 'username' in 'order clause' Query: SELECT recipients FROM mybb_privatemessages WHERE folder='2' AND uid='1' ORDER BY username ASC LIMIT 0, 20

@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 9, 2013

That last commit should fix the SQL error. Completely forgot the privatemessages table didn't store the username.

nmalcolm pushed a commit that referenced this pull request Jun 9, 2013
Ability to sort Private Messages in inbox and other folders
@nmalcolm nmalcolm merged commit 156026b into mybb:feature Jun 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants