Ability to sort Private Messages in inbox and other folders #70

Merged
merged 3 commits into from Jun 9, 2013

Conversation

Projects
None yet
2 participants
@PaulBender
Member

PaulBender commented May 5, 2013

From my list of suggestions I posted here; this adds the ability to sort your private message folders by either subject, username or date sent.

@nmalcolm

This comment has been minimized.

Show comment
Hide comment
@nmalcolm

nmalcolm Jun 9, 2013

Contributor

These are some issues here. Ordering "Sent To" in Sent Items or Drafts produces an SQL error.

SQL Error: 1054 - Unknown column 'username' in 'order clause' Query: SELECT recipients FROM mybb_privatemessages WHERE folder='2' AND uid='1' ORDER BY username ASC LIMIT 0, 20

Contributor

nmalcolm commented Jun 9, 2013

These are some issues here. Ordering "Sent To" in Sent Items or Drafts produces an SQL error.

SQL Error: 1054 - Unknown column 'username' in 'order clause' Query: SELECT recipients FROM mybb_privatemessages WHERE folder='2' AND uid='1' ORDER BY username ASC LIMIT 0, 20

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 9, 2013

Member

That last commit should fix the SQL error. Completely forgot the privatemessages table didn't store the username.

Member

PaulBender commented Jun 9, 2013

That last commit should fix the SQL error. Completely forgot the privatemessages table didn't store the username.

nmalcolm pushed a commit that referenced this pull request Jun 9, 2013

Nathan Malcolm
Merge pull request #70 from PaulBender/feature
Ability to sort Private Messages in inbox and other folders

@nmalcolm nmalcolm merged commit 156026b into mybb:feature Jun 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment