-
Notifications
You must be signed in to change notification settings - Fork 45
Use validation for routes with id #106
Comments
We should be doing this for all new controller code as of now and make a list of existing cases that need to be addressed retrospectively. |
Well, existing cases are all controllers/routes which need an id. (forum show, all topics (either forum, topic or post), like, quote, conversations, user profile) |
@JN-Jones yup, I'll start adding a list to this issue. If you could add any I miss, that would really help :) |
So we should be doing two queries rather than one? No thanks... A simple fix would be to change the repositories to use |
Another thing I forgot: The |
Also |
True. |
As @wpillar mentioned here: Instead of doing
in the controller we should add custom request classes to those functions which use the validor:
id => exists:elTable
ForumController
TopicController
PostController
The text was updated successfully, but these errors were encountered: