jquery.confirm with bootstrap 3 #10

Merged
merged 3 commits into from Jan 6, 2014

Conversation

Projects
None yet
2 participants
@RusselVela

In this fork I just cloned the original library (v1.3) and modified it to work with bootstrap 3.0.2.
Additionally, i created a demo page with the new library (jquery.confirm.bs3.js). It can be found on demobs3/index.html

One last feature. Now the jquery.confirm.bs3.js library can take a 'title parameter to show on the dialog. If no title is passed, then the title section of the modal is not displayed. (It looks exactly as the modal from the v1.3).

Minified version of jquery.confirm.bs3.js provided.

Renamed the original library and its minified version to better clarify which one to use according to the version of
bootstrap used.

rvela added some commits Nov 27, 2013

rvela rvela
Added jquery.confirm.bs3.js to be used with bootstrap 3
Added demobs3/index.html to demonstrate de use of the jquery.confirm.bs3.js library
rvela rvela
Renamed the original library and its minified version to clarify
which one to use according to the bootstrap version.

jquery.confirm.js renamed to jquery.confirm.bs2.js
jquery.confirm.min renamed to jquery.confirm.bs2.min.js
@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Nov 27, 2013

Member

Thanks for this.

I'll take some time to review it, it's a good change since BS3 is the way to go, but I'm wondering if there's any way to have a version that's compatible with both versions.

Btw, unrelated, but it seems your commits are not linked to your github profile (username is grey and not clickable). It's not a problem at all, it's just that if you want your contributions to be linked to your profile, you may want to look how to configure your account (see https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile).

Member

mnapoli commented Nov 27, 2013

Thanks for this.

I'll take some time to review it, it's a good change since BS3 is the way to go, but I'm wondering if there's any way to have a version that's compatible with both versions.

Btw, unrelated, but it seems your commits are not linked to your github profile (username is grey and not clickable). It's not a problem at all, it's just that if you want your contributions to be linked to your profile, you may want to look how to configure your account (see https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile).

@RusselVela

This comment has been minimized.

Show comment
Hide comment
@RusselVela

RusselVela Nov 28, 2013

Thanks for the advice, im not used to make contributions, and most the time
i use github for personal development, so im a bit newbee on that stuff.

I will look up at the settings.

Im fot the feature of both versions. I think it could be a bit hard. Since
the bs3 has changed some key css classes. And in particular, the skeleton
of the modal is different from the skeleton of bs2. I'll take a look to see
if there's a way to do it. Its clear that just one library is far better
than two.

2013/11/27 Matthieu Napoli notifications@github.com

Thanks for this.

I'll take some time to review it, it's a good change since BS3 is the way
to go, but I'm wondering if there's any way to have a version that's
compatible with both versions.

Btw, unrelated, but it seems your commits are not linked to your github
profile (username is grey and not clickable). It's not a problem at all,
it's just that if you want your contributions to be linked to your profile,
you may want to look how to configure your account (see
https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile
).


Reply to this email directly or view it on GitHubhttps://github.com/myclabs/jquery.confirm/pull/10#issuecomment-29427839
.

Thanks for the advice, im not used to make contributions, and most the time
i use github for personal development, so im a bit newbee on that stuff.

I will look up at the settings.

Im fot the feature of both versions. I think it could be a bit hard. Since
the bs3 has changed some key css classes. And in particular, the skeleton
of the modal is different from the skeleton of bs2. I'll take a look to see
if there's a way to do it. Its clear that just one library is far better
than two.

2013/11/27 Matthieu Napoli notifications@github.com

Thanks for this.

I'll take some time to review it, it's a good change since BS3 is the way
to go, but I'm wondering if there's any way to have a version that's
compatible with both versions.

Btw, unrelated, but it seems your commits are not linked to your github
profile (username is grey and not clickable). It's not a problem at all,
it's just that if you want your contributions to be linked to your profile,
you may want to look how to configure your account (see
https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile
).


Reply to this email directly or view it on GitHubhttps://github.com/myclabs/jquery.confirm/pull/10#issuecomment-29427839
.

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Dec 19, 2013

Member

Sorry for taking so much time, I forgot about this.

What we can do is simply have the 1.* branch (1.3.0 being the last version) for Bootstrap 2, and start the 2.* releases for Bootstrap 3. The plugin is stable anyway, so I think it's the best solution.

Do you have time to remove the *.bs2.js files and keep only the Bootstrap 3 version? If you don't have time that's ok we'll probably do it in january.

Member

mnapoli commented Dec 19, 2013

Sorry for taking so much time, I forgot about this.

What we can do is simply have the 1.* branch (1.3.0 being the last version) for Bootstrap 2, and start the 2.* releases for Bootstrap 3. The plugin is stable anyway, so I think it's the best solution.

Do you have time to remove the *.bs2.js files and keep only the Bootstrap 3 version? If you don't have time that's ok we'll probably do it in january.

mnapoli added a commit that referenced this pull request Jan 6, 2014

Merge pull request #10 from RusselVela/master
jquery.confirm with bootstrap 3

@mnapoli mnapoli merged commit 1a523f9 into myclabs:master Jan 6, 2014

@mnapoli mnapoli added the enhancement label Jul 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment