New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt clang's diagnostics to beluga #27

Open
mycoboco opened this Issue Dec 14, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@mycoboco
Owner

mycoboco commented Dec 14, 2015

  • inconsistent printf arguments
  • range highlight
  • "fix it" - correct common mistakes
  • display lines before and after macro expansion (#3)
  • missing terminating semicolon should be diagnosed at the end of line rather than at the start of next line (#34)
  • warn explicit out-of-bound; int a[100]; return a[100];
  • warn memset(p, 0, sizeof(p))
  • warn using bit ops in comparison without parentheses (#51)
  • warn mixing && and || without parentheses (#49)
  • warn if (a = b) but not if ((a = b)) (#50)
  • warn 42 + b? x: y without parentheses (#53; decided not to implement)
  • warn empty body of if (#47)
  • diagnose foo_t P = 42; as unknown type (#54)
  • better diagnostics for (undecled_id) taking it as cast (#55)
@mycoboco

This comment has been minimized.

Show comment
Hide comment
@mycoboco

mycoboco Mar 30, 2016

Owner

Need to consider issuing a warning for 42 + b? x: y or b? x: y + 42 is really worthwhile.

Owner

mycoboco commented Mar 30, 2016

Need to consider issuing a warning for 42 + b? x: y or b? x: y + 42 is really worthwhile.

@mycoboco

This comment has been minimized.

Show comment
Hide comment
@mycoboco

mycoboco Jan 7, 2017

Owner

Decided not to support the "fix it" feature.

Owner

mycoboco commented Jan 7, 2017

Decided not to support the "fix it" feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment