Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom node name #464

Closed
seant100 opened this Issue Sep 3, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@seant100
Copy link

seant100 commented Sep 3, 2018

When a node presents itself then MyController will set the Node name to the sketch name in the presentation.
I now have 2 nodes running the same sketch with auto id.
I can then set a custom node name by editing each of the nodes.
However when I reboot the node or click on the "refresh node info" under actions then the name resets back to the sketch name as sent by the presentation.

@jkandasa jkandasa added the enhancement label Sep 3, 2018

@jkandasa jkandasa self-assigned this Sep 6, 2018

@nikolac

This comment has been minimized.

Copy link

nikolac commented Sep 11, 2018

+1 this fix my biggest annoyance

@jkandasa jkandasa added this to the 1.4.0 milestone Sep 12, 2018

jkandasa added a commit that referenced this issue Sep 19, 2018

@jkandasa

This comment has been minimized.

Copy link
Member

jkandasa commented Sep 19, 2018

@seant100 @nikolac I have added a fix in SNAPSHOT version.
Kindly check it and update.

When editing a node you should add "lockNode": true property in node properties. If you have more number of fields in properties, at the end add comma and attach this property.
NOTE: Should not use " for the value. It should be true or false

image

@seant100

This comment has been minimized.

Copy link
Author

seant100 commented Sep 19, 2018

@jkandasa Tried this and seems to be working. If any revert back to the sketch name I will let you know. Otherwise all is ok now.
Thank you !

@seant100

This comment has been minimized.

Copy link
Author

seant100 commented Sep 19, 2018

@jkandasa Just want to know why this cannot be the default behaviour? If a new node presents itself then it can set the name using the sketch name. After that it should NEVER override the name.

@jkandasa

This comment has been minimized.

Copy link
Member

jkandasa commented Sep 19, 2018

@seant100 Sometimes a user wants to rename node name via sketch. So I kept sketch name as default. Users like you can lock the node name.

@seant100 seant100 closed this Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.